Skip to content

[Shopify] Fix VAT Registration No. test for BE gate #6606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
onbuyuka wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Shopify] Fix VAT Registration No. test for BE gate #6606

onbuyuka wants to merge 1 commit into from
+12 −10

Conversation

@onbuyuka
Copy link
Contributor

@onbuyuka onbuyuka commented Feb 10, 2026 •
edited by github-actions bot
Loading

Summary

  • Fix UnitTestUpdateTaxRegistrationIdForVATRegistrationNo failing in RunALUnitTests_BE_Extensions gate
  • Replace country code check with EventSubscriber on OnBeforeValidateVATRegistrationNo to bypass localization-specific validation
  • The previous fix checked CompanyInformation."Country/Region Code" = 'BE', but the BE gate runs unit tests in an "Empty Company" where the country is blank — and the BE layer's DetermineCountry('') treats blank as Belgian

Test plan

  • Verify UnitTestUpdateTaxRegistrationIdForVATRegistrationNo passes in RunALUnitTests_BE_Extensions
  • Verify all other tests in Shpfy Tax Id Mapping Test codeunit still pass
  • Verify W1 unit tests are not affected

Fixes AB#618120

🤖 Generated with Claude Code

@onbuyuka onbuyuka requested a review from a team as a code owner February 10, 2026 15:26
@github-actions github-actions bot added the AL: Apps (W1) Add-on apps for W1 label Feb 10, 2026
@github-actions github-actions bot added this to the Version 28.0 milestone Feb 10, 2026
@onbuyuka onbuyuka changed the title Fix Shopify VAT Registration No. test for BE gate [Shopify] Fix VAT Registration No. test for BE gate Feb 10, 2026
@onbuyuka @claude
Fix Shopify VAT Registration No. test failing in BE gate
80193c7 
Use EventSubscriber to bypass localization-specific VAT Registration
No. validation instead of checking CompanyInformation country code.
The previous fix only handled the case where CompanyInformation had
'BE' as Country/Region Code, but the BE gate runs unit tests in an
Empty Company where the country is blank - and the BE layer treats
blank as Belgian.

Fixes AB#618120

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@onbuyuka onbuyuka force-pushed the onbuyuka/fix-be-vat-registration-test branch from 70a298d to 80193c7 Compare February 10, 2026 15:29
@onbuyuka onbuyuka enabled auto-merge (squash) February 10, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

AL: Apps (W1) Add-on apps for W1

Projects

None yet

Milestone

Version 28.0

Development

Successfully merging this pull request may close these issues.

1 participant

@onbuyuka