Fix milestone assignment for release branch PRs #6512
+15
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Build: Automation
github-actions
bot
added
the
Build: scripts & configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the WorkitemValidation workflow to correctly assign milestones to PRs targeting release branches.
The workflow uses
pull_request_targetwhich, with a bareactions/checkout, always checks out the default branch (main). This means PRs targeting release branches (e.g.releases/27.3) get the milestone frommain(e.g. "Version 28.0") instead of the correct release branch milestone.The fix adds
ref: ${{ github.event.pull_request.base.ref }}to the checkout steps so the correct branch is checked out.Work Item(s)
Fixes AB#620875