[Shopify] Item Attributes as Product Options

src/Apps/W1/Shopify/App/src/Base/Tables/ShpfyShop.Table.al

@@ -12,6 +12,7 @@ using Microsoft.Finance.SalesTax;
 using Microsoft.Finance.VAT.Setup;
 using Microsoft.Foundation.Address;
 using Microsoft.Inventory.Item;
+using Microsoft.Inventory.Item.Attribute;
 using Microsoft.Inventory.Location;
 using Microsoft.Sales.Customer;
 using Microsoft.Sales.Pricing;
@@ -300,6 +301,9 @@ table 30102 "Shpfy Shop"
 
             trigger OnValidate()
             begin
+                if "UoM as Variant" then
+                    VerifyNoItemAttributesAsOptions();
+
                 if "UoM as Variant" and ("Option Name for UoM" = '') then
                     "Option Name for UoM" := 'Unit of Measure';
             end;
@@ -1090,4 +1094,14 @@ table 30102 "Shpfy Shop"
     end;
 #pragma warning restore AL0432
 #endif
+
+    local procedure VerifyNoItemAttributesAsOptions()
+    var
+        ItemAttribute: Record "Item Attribute";
+        UoMVariantUnavailableErr: Label 'You cannot enable this setting because one or more Item Attributes are configured with "Incl. in Product Sync" set to "As Option".';
+    begin
+        ItemAttribute.SetRange("Shpfy Incl. in Product Sync", "Shpfy Incl. in Product Sync"::"As Option");
+        if not ItemAttribute.IsEmpty() then
+            Error(UoMVariantUnavailableErr);
+    end;
 }

src/Apps/W1/Shopify/App/src/Products/Codeunits/ShpfyCreateItemAsVariant.Codeunit.al

@@ -6,6 +6,7 @@
 namespace Microsoft.Integration.Shopify;
 
 using Microsoft.Inventory.Item;
+using Microsoft.Inventory.Item.Attribute;
 
 codeunit 30343 "Shpfy Create Item As Variant"
 {
@@ -33,21 +34,33 @@ codeunit 30343 "Shpfy Create Item As Variant"
     /// <param name="Item">The item to be added as a variant.</param>
     internal procedure CreateVariantFromItem(var Item: Record "Item")
     var
+        ProductItem: Record Item;
         TempShopifyVariant: Record "Shpfy Variant" temporary;
+        ProductExport: Codeunit "Shpfy Product Export";
+        ItemAttributeIds: List of [Integer];
     begin
         if Item.SystemId = ShopifyProduct."Item SystemId" then
             exit;
 
         CreateProduct.CreateTempShopifyVariantFromItem(Item, TempShopifyVariant);
         TempShopifyVariant.Title := Item."No.";
 
-        if not ShopifyProduct."Has Variants" and (OptionName = 'Title') then begin
-            // Shopify automatically deletes the default variant (Title) when adding a new one so first we need to update the default variant to have a different name (Variant)
-            UpdateProductOption('Variant');
-            TempShopifyVariant."Option 1 Name" := 'Variant';
-        end else
-            TempShopifyVariant."Option 1 Name" := CopyStr(OptionName, 1, MaxStrLen(TempShopifyVariant."Option 1 Name"));
-        TempShopifyVariant."Option 1 Value" := Item."No.";
+        if ProductItem.GetBySystemId(ShopifyProduct."Item SystemId") then
+            ProductExport.GetItemAttributeIDsMarkedAsOption(ProductItem, ItemAttributeIds);
+
+        if ItemAttributeIds.Count = 0 then begin
+            if not ShopifyProduct."Has Variants" and (OptionName = 'Title') then begin
+                // Shopify automatically deletes the default variant (Title) when adding a new one so first we need to update the default variant to have a different name (Variant)
+                UpdateProductOption('Variant');
+                TempShopifyVariant."Option 1 Name" := 'Variant';
+            end else
+                TempShopifyVariant."Option 1 Name" := CopyStr(OptionName, 1, MaxStrLen(TempShopifyVariant."Option 1 Name"));
+            TempShopifyVariant."Option 1 Value" := Item."No.";
+        end else begin
+            ProductExport.SetShop(Shop);
+            if not ProductExport.ValidateItemAttributesAsProductOptionsForNewVariant(TempShopifyVariant, Item, '', ShopifyProduct.Id) then
+                exit;
+        end;
 
         Events.OnAfterCreateTempShopifyVariant(Item, TempShopifyVariant);
         TempShopifyVariant.Modify();
@@ -65,7 +78,10 @@ codeunit 30343 "Shpfy Create Item As Variant"
     /// </summary>
     internal procedure CheckProductAndShopSettings()
     var
+        ProductItem: Record Item;
         CommunicationMgt: Codeunit "Shpfy Communication Mgt.";
+        ProductExport: Codeunit "Shpfy Product Export";
+        ItemAttributeIds: List of [Integer];
         Options: Dictionary of [Text, Text];
         MultipleOptionsErr: Label 'The product has more than one option. Items cannot be added as variants to a product with multiple options.';
         UOMAsVariantEnabledErr: Label 'Items cannot be added as variants to a product with the "%1" setting enabled for this store.', Comment = '%1 - UoM as Variant field caption';
@@ -75,8 +91,14 @@ codeunit 30343 "Shpfy Create Item As Variant"
 
         Options := ProductApi.GetProductOptions(ShopifyProduct.Id);
 
-        if Options.Count > 1 then
-            Error(MultipleOptionsErr);
+        if ProductItem.GetBySystemId(ShopifyProduct."Item SystemId") then
+            ProductExport.GetItemAttributeIDsMarkedAsOption(ProductItem, ItemAttributeIds);
+
+        if ItemAttributeIds.Count = 0 then begin
+            if Options.Count > 1 then
+                Error(MultipleOptionsErr);
+        end else
+            VerifyProductOptionsMatchesItemAttributes(Options, ProductItem);
 
         OptionId := CommunicationMgt.GetIdOfGId(Options.Keys.Get(1));
         OptionName := Options.Values.Get(1);
@@ -98,6 +120,28 @@ codeunit 30343 "Shpfy Create Item As Variant"
         OptionName := NewOptionName;
     end;
 
+    local procedure VerifyProductOptionsMatchesItemAttributes(Options: Dictionary of [Text, Text]; Item: Record Item)
+    var
+        ItemAttributeValueMapping: Record "Item Attribute Value Mapping";
+        ItemAttribute: Record "Item Attribute";
+        ShopifyOptionName: Text;
+        MissingItemAttributeErr: Label 'Item cannot be added as variant because the Shopify product option "%1" does not have a corresponding Item Attribute marked as "As Option" assigned to the parent Item.', Comment = '%1 - Shopify Option Name';
+    begin
+        foreach ShopifyOptionName in Options.Values do begin
+            ItemAttribute.SetRange(Name, ShopifyOptionName);
+            ItemAttribute.SetRange(Blocked, false);
+            ItemAttribute.SetRange("Shpfy Incl. in Product Sync", ItemAttribute."Shpfy Incl. in Product Sync"::"As Option");
+            if ItemAttribute.FindFirst() then begin
+                ItemAttributeValueMapping.SetRange("Table ID", Database::Item);
+                ItemAttributeValueMapping.SetRange("No.", Item."No.");
+                ItemAttributeValueMapping.SetRange("Item Attribute ID", ItemAttribute.ID);
+                if ItemAttributeValueMapping.IsEmpty() then
+                    Error(MissingItemAttributeErr, ShopifyOptionName);
+            end else
+                Error(MissingItemAttributeErr, ShopifyOptionName);
+        end;
+    end;
+
     local procedure SetShop(ShopCode: Code[20])
     begin
         Shop.Get(ShopCode);

src/Apps/W1/Shopify/App/src/Products/Codeunits/ShpfyCreateProduct.Codeunit.al

@@ -57,6 +57,9 @@ codeunit 30174 "Shpfy Create Product"
         TempShopifyVariant: Record "Shpfy Variant" temporary;
         TempShopifyTag: Record "Shpfy Tag" temporary;
     begin
+        if not ProductExport.CheckItemAttributesCompatibleForProductOptions(Item) then
+            exit;
+
         CreateTempProduct(Item, TempShopifyProduct, TempShopifyVariant, TempShopifyTag);
         if not VariantApi.FindShopifyProductVariant(TempShopifyProduct, TempShopifyVariant) then
             ProductId := ProductApi.CreateProduct(TempShopifyProduct, TempShopifyVariant, TempShopifyTag)
@@ -161,6 +164,7 @@ codeunit 30174 "Shpfy Create Product"
             end else
                 CreateTempShopifyVariantFromItem(Item, TempShopifyVariant);
 
+        ProductExport.FillProductOptionsForShopifyVariants(Item, TempShopifyVariant, TempShopifyProduct);
         TempShopifyProduct.Insert(false);
         Events.OnAfterCreateTempShopifyProduct(Item, TempShopifyProduct, TempShopifyVariant, TempShopifyTag);
     end;