-
Notifications
You must be signed in to change notification settings - Fork 324
Add Microsoft Graph API Support to SharePoint Connector #5833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tinestaric
wants to merge
8
commits into
microsoft:main
Choose a base branch
from
tinestaric:EFS-SharepointGraphConnector
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
768a064
Add support for Microsoft Graph API in SharePoint Connector
8e7bd91
Fix parameter assignment for certificate in SetParameters method
a57ebea
Refactor SharePoint file operations to use SharePointAccount record i…
4c5b219
Implement file upload size handling in SharePoint Graph Helper
24f05d8
Update file upload size threshold to 4MB in SharePoint Graph Helper
dfbd7e5
Remove unused namespace
10cd320
Add validation trigger for "Use Graph API" field in SharePoint Accoun…
Bertverbeek4PS 05295dd
Merge branch 'main' into EFS-SharepointGraphConnector
JesperSchulz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,7 +34,7 @@ table 4580 "Ext. SharePoint Account" | |
| field(5; "Base Relative Folder Path"; Text[2048]) | ||
| { | ||
| Caption = 'Base Relative Folder Path'; | ||
| ToolTip = 'Specifies the folder path relative to the site collection. Start with the document library or folder name (e.g., Shared Documents/Reports). This path can be copied from the URL of the folder in SharePoint after the site collection (e.g., /Shared Documents/Reports from https://mysharepoint.sharepoint.com/sites/ProjectX/Shared%20Documents/Reports).'; | ||
| ToolTip = 'Specifies the base folder path. For SharePoint REST API: Use the full server-relative path including the site (e.g., /sites/ProjectX/Shared Documents/Reports). For Microsoft Graph API: Use only the path relative to the document library (e.g., Reports). When using Graph API, the path should not include the site or document library root, only the folders within the library.'; | ||
| } | ||
| field(6; "Tenant Id"; Guid) | ||
| { | ||
|
|
@@ -50,6 +50,7 @@ table 4580 "Ext. SharePoint Account" | |
| } | ||
| field(8; "Client Secret Key"; Guid) | ||
| { | ||
| Caption = 'Client Secret Key'; | ||
| Access = Internal; | ||
| DataClassification = SystemMetadata; | ||
| } | ||
|
|
@@ -66,14 +67,23 @@ table 4580 "Ext. SharePoint Account" | |
| } | ||
| field(11; "Certificate Key"; Guid) | ||
| { | ||
| Caption = 'Certificate Key'; | ||
| Access = Internal; | ||
| AllowInCustomizations = Never; | ||
| DataClassification = SystemMetadata; | ||
| } | ||
| field(12; "Certificate Password Key"; Guid) | ||
| { | ||
| Caption = 'Certificate Password Key'; | ||
| Access = Internal; | ||
| AllowInCustomizations = Never; | ||
| DataClassification = SystemMetadata; | ||
| } | ||
| field(13; "Use Graph API"; Boolean) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should be |
||
| { | ||
| Caption = 'Use Microsoft Graph API'; | ||
| ToolTip = 'Specifies whether to use Microsoft Graph API or SharePoint REST API. Microsoft Graph API supports downloading files larger than 150 MB through chunked transfers. Note: Requires Microsoft Graph permissions (Sites.ReadWrite.All) configured in your app registration instead of SharePoint permissions.'; | ||
| } | ||
| } | ||
|
|
||
| keys | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we show this message when check it from true to false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I get it now. Basically, you control both connector options with this boolean
I understand that there are no other implementations besides Legacy REST API and Graph API.
But why don't we just make it an enum value? Without using interfaces. Just to be more readable. In this case, we can, for example, make Graph API the default value, and it will look much better than
boolean = trueby default.Also, maybe it will be another implementation in future, low chance, but worth to mention