Skip to content

Audit and narrow overly broad detection rules with comprehensive test coverage #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Audit and narrow overly broad detection rules with comprehensive test coverage #635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
490a782
Initial plan
Copilot Feb 14, 2026
a818576
Phase 1: Fix critical performance issues in rules
Copilot Feb 14, 2026
db10eae
Phase 2: Improve pattern precision for authentication and RSA
Copilot Feb 14, 2026
b9df00c
Phase 3: Improve serialization and device detection patterns
Copilot Feb 14, 2026
69b17f8
Address code review feedback: simplify patterns and improve consistency
Copilot Feb 14, 2026
20a37db
Add must-match and must-not-match test cases to improved rules
Copilot Feb 14, 2026
8569b75
Fix test cases to validate correctly against rule patterns
Copilot Feb 14, 2026
f7c03c2
Fix schema validation: capitalize severity, type, confidence, and sco…
Copilot Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
151 changes: 97 additions & 54 deletions AppInspector/rules/default/cryptography/ciphers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,23 @@
"tags": [
"Cryptography.Cipher.AES"
],
"severity": "moderate",
"severity": "Moderate",
"patterns": [
{
"pattern": "AES",
"type": "string",
"type": "String",
"scopes": [
"code"
"Code"
],
"confidence": "high"
"confidence": "High"
},
{
"pattern": "AES-?(128|192|256)|Rijndael",
"type": "regexword",
"type": "RegexWord",
"scopes": [
"code"
"Code"
],
"confidence": "high"
"confidence": "High"
}
]
},
Expand All @@ -33,15 +33,15 @@
"tags": [
"Cryptography.Cipher.3DES"
],
"severity": "moderate",
"severity": "Moderate",
"patterns": [
{
"pattern": "3DES|TripleDES",
"type": "regexword",
"type": "RegexWord",
"scopes": [
"code"
"Code"
],
"confidence": "high"
"confidence": "High"
}
]
},
Expand All @@ -52,23 +52,23 @@
"tags": [
"Cryptography.Cipher.RC"
],
"severity": "moderate",
"severity": "Moderate",
"patterns": [
{
"pattern": "RC([2456])",
"type": "regexword",
"type": "RegexWord",
"scopes": [
"code"
"Code"
],
"confidence": "high"
"confidence": "High"
},
{
"pattern": "arc4random",
"type": "string",
"type": "String",
"scopes": [
"code"
"Code"
],
"confidence": "high",
"confidence": "High",
"modifiers": [
"i"
]
Expand All @@ -82,15 +82,15 @@
"tags": [
"Cryptography.Cipher.Salsa20"
],
"severity": "moderate",
"severity": "Moderate",
"patterns": [
{
"pattern": "Salsa20",
"type": "string",
"type": "String",
"scopes": [
"code"
"Code"
],
"confidence": "high",
"confidence": "High",
"modifiers": [
"i"
]
Expand All @@ -104,15 +104,15 @@
"tags": [
"Cryptography.Cipher.ChaCha"
],
"severity": "moderate",
"severity": "Moderate",
"patterns": [
{
"pattern": "ChaCha",
"type": "string",
"type": "String",
"scopes": [
"code"
"Code"
],
"confidence": "high",
"confidence": "High",
"modifiers": [
"i"
]
Expand All @@ -126,16 +126,37 @@
"tags": [
"Cryptography.Cipher.CipherMode"
],
"severity": "critical",
"severity": "Critical",
"patterns": [
{
"pattern": "CBC|CTR|ECB|OFB|CFB|CTS|PCBC|GMAC|XCBC|IACBC|IAPM|EAX|OCB|CWC|AEAD|LRW|XEX|XTS|CMC|EME|CBCMAC|OMAC|PMAC",
"type": "regexword",
"pattern": "CipherMode\\.|Mode\\s*[=:]\\s*(CBC|CTR|ECB|OFB|CFB|CTS|PCBC|GMAC|XCBC|IACBC|IAPM|EAX|OCB|CWC|AEAD|LRW|XEX|XTS|CMC|EME|CBCMAC|OMAC|PMAC)",
"type": "Regex",
"scopes": [
"code"
"Code"
],
"confidence": "low"
"confidence": "High"
},
{
"pattern": "(AES|DES|3DES|Blowfish|Twofish)[-_](CBC|CTR|ECB|OFB|CFB|GCM)",
"type": "Regex",
"scopes": [
"Code"
],
"confidence": "High"
}
],
"must-match": [
"cipher.Mode = CipherMode.CBC;",
"algorithm = new AesManaged { Mode = CipherMode.ECB };",
"cipher = AES-CBC",
"const mode = 'AES_GCM';",
"enc = new Blowfish-CTR()"
],
"must-not-match": [
"// CBC Radio broadcasts at 5pm",
"String cbc_variable = 'test';",
"ecb_module = load_module('ecb');",
"medical_term = 'ECG not ECB';"
]
},
{
Expand All @@ -148,31 +169,31 @@
"tags": [
"Cryptography.Cipher.RSA"
],
"severity": "moderate",
"severity": "Moderate",
"patterns": [
{
"pattern": "RSACng|RSACryptoServiceProvider|RSAEncryptionPadding|RSAOAEPKeyExchangeDeformatter|X509AsymmetricSecurityKey",
"type": "regexword",
"type": "RegexWord",
"scopes": [
"code"
"Code"
],
"confidence": "high"
"confidence": "High"
},
{
"pattern": "RSAOAEPKeyExchangeFormatter|RSAPKCS1KeyExchangeDeformatter|RSAPKCS1",
"type": "regexword",
"type": "RegexWord",
"scopes": [
"code"
"Code"
],
"confidence": "high"
"confidence": "High"
},
{
"pattern": "RSASignaturePadding|RsaProtectedConfigurationProvider|RSACertificateExtensions",
"type": "regexword",
"type": "RegexWord",
"scopes": [
"code"
"Code"
],
"confidence": "high"
"confidence": "High"
}
]
},
Expand All @@ -183,30 +204,52 @@
"tags": [
"Cryptography.Cipher.RSA"
],
"severity": "moderate",
"severity": "Moderate",
"patterns": [
{
"pattern": "RSA.*encrypt|RSA.*decrypt|public.?key|private.?key|privkey|pubkey",
"type": "regex",
"pattern": "RSA(?:Encrypt|Decrypt|Sign|Verify)\\(|RSA[_\\.](?:encrypt|decrypt)",
"type": "Regex",
"scopes": [
"code"
"Code"
],
"confidence": "high",
"confidence": "High",
"modifiers": [
"i"
]
},
{
"pattern": "\\b(?:public|private)[_\\.-]?key\\b|\\bprivkey\\b|\\bpubkey\\b",
"type": "Regex",
"scopes": [
"Code"
],
"confidence": "Medium",
"modifiers": [
"i"
]
},
{
"pattern": "rsa",
"type": "regexword",
"type": "RegexWord",
"scopes": [
"code"
"Code"
],
"confidence": "low",
"confidence": "Low",
"modifiers": [
"i"
]
}
],
"must-match": [
"encrypted = RSAEncrypt(plaintext, key);",
"var public_key = cert.PublicKey;",
"const privkey = loadPrivateKey();",
"using RSA rsa = RSA.Create();"
],
"must-not-match": [
"// Public key infrastructure documentation",
"var publicly_available = true;",
"String private_method_key = 'test';"
]
},
{
Expand All @@ -216,16 +259,16 @@
"tags": [
"Cryptography.Encryption.General"
],
"severity": "moderate",
"severity": "Moderate",
"patterns": [
{
"pattern": "encrypt|decrypt|cipher|crypt|symmmetric|asymmetric",
"type": "regex",
"type": "Regex",
"scopes": [
"code",
"comment"
"Code",
"Comment"
],
"confidence": "medium",
"confidence": "Medium",
"modifiers": [
"i"
]
Expand Down
Loading
Loading