Skip to content

4229 create a large variant of radio button#4370

Draft
MI6-711 wants to merge 3 commits intodevelopfrom
4229-create-a-large-variant-of-radio-button
Draft

4229 create a large variant of radio button#4370
MI6-711 wants to merge 3 commits intodevelopfrom
4229-create-a-large-variant-of-radio-button

Conversation

@MI6-711
Copy link
Contributor

@MI6-711 MI6-711 commented Mar 11, 2026

Summary of the changes

Add large variant to ic-radio-group size prop - update imports, create new test, create new stories

Related issue

#4229

Checklist

General

  • Changes to docs package checked and committed.
  • All acceptance criteria reviewed and met.

Testing

  • Relevant unit tests and visual regression tests added.
  • Visual testing against Figma component specification completed.
  • Playground stories in React Storybook up to date, with any prop changes and additions addressed.
  • Compare performance of modified components against develop using Performance addon in React Storybook.

Accessibility

  • Accessibility Insights FastPass performed.
  • A11y unit test added and yields no issues.
  • A11y plug-in on Storybook yields no issues.
  • Manual screen reader testing performed using NVDA and VoiceOver.
  • Manual keyboard testing for keyboard controls and logical focus order.
  • Correct roles used and ARIA attributes used correctly where required.
  • Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

  • Page can be zoomed to 400% with no loss of content.
  • Screen magnifier used with no issues.
  • Text resized to 200% with no loss of content.
  • Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

  • Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
  • Windows High Contrast mode tested with no loss of content.
  • System light and dark mode tested with no loss of content.
  • Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

  • Min/max content examples tested with no loss of content or overflow.
  • All prop combinations work without issue.
  • Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
  • Controlled and uncontrolled input components tested.
  • Props/slots can be updated after initial render.

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2026

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@MI6-711 MI6-711 self-assigned this Mar 11, 2026
@MI6-711 MI6-711 marked this pull request as draft March 11, 2026 14:14
@MI6-711 MI6-711 force-pushed the 4229-create-a-large-variant-of-radio-button branch 2 times, most recently from 11c65ee to d31b3e3 Compare March 12, 2026 12:44
@MI6-711 MI6-711 force-pushed the 4229-create-a-large-variant-of-radio-button branch from d31b3e3 to deb7a35 Compare March 12, 2026 13:39
MI6-711 added 3 commits March 12, 2026 13:59
…disables

change formatting and remove eslint-disables - prettier and linting modified these files
add 'large' variant to ic-radio-group component - add a large radio icon to the group component
add 'large' size to ic-radio-group - change IcSizeNoLarge to IcSize and modify files to accompany
the change
@MI6-711 MI6-711 force-pushed the 4229-create-a-large-variant-of-radio-button branch from deb7a35 to f9ea5e7 Compare March 12, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants