Conversation
|
View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/2937-ic-chip-padding/web-components |
|
Cypress visual tests failed. |
bf57359 to
e6725ef
Compare
GCHQ-Developer-299
left a comment
There was a problem hiding this comment.
Can you squash your two web-components commits together please?
Other than that, this looks okay, seems to replicate the figma changes fine :)
91fcf70 to
6b8a211
Compare
All done :) |
GCHQ-Developer-299
left a comment
There was a problem hiding this comment.
Didn't spot this before but the AG Grid storybook (and screenshot) seems to have broken truncation
efa1ea9 to
53457ce
Compare
…ma designs change padding on ic-chip to reflect the figma designs along with the border radius on medium sized chip
Update visual regression testing after chip padding update
53457ce to
e3e9428
Compare
Summary of the changes
Updating the padding for ic-chip and ic-action-chip to be aligned with the figma designs.
Figma Designs:

Before:



After:


Related issue
#2937
Checklist
General
Testing
Accessibility
Resize/zoom behaviour
System modes
Testing content extremes