Skip to content

2937 ic chip padding#4289

Merged
GCHQ-Developer-299 merged 2 commits intodevelopfrom
2937-ic-chip-padding
Mar 12, 2026
Merged

2937 ic chip padding#4289
GCHQ-Developer-299 merged 2 commits intodevelopfrom
2937-ic-chip-padding

Conversation

@GCHQDeveloper253
Copy link
Contributor

@GCHQDeveloper253 GCHQDeveloper253 commented Feb 23, 2026

Summary of the changes

Updating the padding for ic-chip and ic-action-chip to be aligned with the figma designs.

Figma Designs:
image image

Before:
imageimage
image

After:
image image
image

Related issue

#2937

Checklist

General

  • Changes to docs package checked and committed.
  • All acceptance criteria reviewed and met.

Testing

  • Relevant unit tests and visual regression tests added.
  • Visual testing against Figma component specification completed.
  • Playground stories in React Storybook up to date, with any prop changes and additions addressed.
  • Compare performance of modified components against develop using Performance addon in React Storybook.

Accessibility

  • Accessibility Insights FastPass performed.
  • A11y unit test added and yields no issues.
  • A11y plug-in on Storybook yields no issues.
  • Manual screen reader testing performed using NVDA and VoiceOver.
  • Manual keyboard testing for keyboard controls and logical focus order.
  • Correct roles used and ARIA attributes used correctly where required.
  • Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

  • Page can be zoomed to 400% with no loss of content.
  • Screen magnifier used with no issues.
  • Text resized to 200% with no loss of content.
  • Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

  • Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
  • Windows High Contrast mode tested with no loss of content.
  • System light and dark mode tested with no loss of content.
  • Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

  • Min/max content examples tested with no loss of content or overflow.
  • All prop combinations work without issue.
  • Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
  • Controlled and uncontrolled input components tested.
  • Props/slots can be updated after initial render.

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@GCHQDeveloper253 GCHQDeveloper253 force-pushed the 2937-ic-chip-padding branch 2 times, most recently from bf57359 to e6725ef Compare March 3, 2026 12:11
@GCHQDeveloper253 GCHQDeveloper253 marked this pull request as ready for review March 3, 2026 12:49
Copy link
Contributor

@GCHQ-Developer-299 GCHQ-Developer-299 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash your two web-components commits together please?

Other than that, this looks okay, seems to replicate the figma changes fine :)

@GCHQDeveloper253
Copy link
Contributor Author

Can you squash your two web-components commits together please?

Other than that, this looks okay, seems to replicate the figma changes fine :)

All done :)

Copy link
Contributor

@GCHQ-Developer-299 GCHQ-Developer-299 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't spot this before but the AG Grid storybook (and screenshot) seems to have broken truncation

@GCHQ-Developer-530 GCHQ-Developer-530 force-pushed the 2937-ic-chip-padding branch 3 times, most recently from efa1ea9 to 53457ce Compare March 12, 2026 11:31
GCHQDeveloper253 and others added 2 commits March 12, 2026 11:36
…ma designs

change padding on ic-chip to reflect the figma designs along with the border radius on medium sized
chip
Update visual regression testing after chip padding update
@GCHQ-Developer-299 GCHQ-Developer-299 merged commit 7683cf1 into develop Mar 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants