Skip to content

3857: Upgrade Stencil and TypeScript#4214

Draft
ec1467 wants to merge 9 commits intodevelopfrom
3857-upgrade-stencil
Draft

3857: Upgrade Stencil and TypeScript#4214
ec1467 wants to merge 9 commits intodevelopfrom
3857-upgrade-stencil

Conversation

@ec1467
Copy link
Contributor

@ec1467 ec1467 commented Jan 26, 2026 •
edited
Loading

Summary of the changes

  • Upgraded Stencil to v4.41.1 in web-components and canary-web-components.
  • This had the knock-on effect of requiring an upgrade of TypeScript to v5.3.3 in react and canary-react (see Upgrade TypeScript to v5.2/3 in the React package #4193).
  • All packages build and pack, everything seems to be running in the test app.
  • Unit tests updated, snapshots updated. Various bits of miscellaneous missed documentation have been updated by the build process (including recent changes to the canary-web-components).

Related issue

#4193

Checklist

  • Run tests
  • Build and pack
  • Try in test app

General

  • Changes to docs package checked and committed.
  • All acceptance criteria reviewed and met.

@ec1467 ec1467 requested a review from a team January 26, 2026 15:54
@ec1467 ec1467 self-assigned this Jan 26, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2026

View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/3857-upgrade-stencil/web-components
View your React branch deployment here: https://mi6.github.io/ic-ui-kit/branches/3857-upgrade-stencil/react

@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2026

View your canary branch deployment here: https://mi6.github.io/ic-ui-kit/branches/3857-upgrade-stencil/canary-web-components
View your canary React branch deployment here: https://mi6.github.io/ic-ui-kit/branches/3857-upgrade-stencil/canary-react

@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2026

Cypress visual tests failed.
View the image diff here: https://github.com/mi6/ic-ui-kit/tree/gh-pages/branches/3857-upgrade-stencil/cypress-image-diff-screenshots/diff
View the html report here: https://mi6.github.io/ic-ui-kit/branches/3857-upgrade-stencil/cypress-image-diff-html-report/cypress-image-diff-html-report.html

GCHQ-Developer-299
GCHQ-Developer-299 requested changes Jan 27, 2026
View reviewed changes
Copy link
Contributor

@GCHQ-Developer-299 GCHQ-Developer-299 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the failure in static analysis tests will prevent you updating the cypress images too, but fingers crossed after that they'll pass :)

GCHQ-Developer-112
GCHQ-Developer-112 reviewed Jan 27, 2026
View reviewed changes
Copy link
Contributor

@GCHQ-Developer-112 GCHQ-Developer-112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some unexpected line removals in a number of the component READMEs

Not sure if this is out of scope but it would be good to have a review of the audit-ci to see if any exceptions can be removed

@ec1467 ec1467 force-pushed the 3857-upgrade-stencil branch 8 times, most recently from 759a876 to 33173d5 Compare February 9, 2026 14:13
@ec1467 ec1467 force-pushed the 3857-upgrade-stencil branch 5 times, most recently from 880fc7e to 68fbb77 Compare February 13, 2026 17:19
@ec1467 ec1467 force-pushed the 3857-upgrade-stencil branch 4 times, most recently from b6ea864 to 15e9145 Compare February 18, 2026 16:45
@ec1467 ec1467 marked this pull request as draft February 18, 2026 16:55
@jd3267 jd3267 force-pushed the 3857-upgrade-stencil branch 3 times, most recently from 1a9ee36 to 395082d Compare March 5, 2026 12:06
@GCHQ-Developer-847
Copy link
Contributor

GCHQ-Developer-847 commented Mar 5, 2026

Just rebased so that I am working with an up-to-date base branch for #4277 :)

@ec1467 ec1467 force-pushed the 3857-upgrade-stencil branch from 7b7178b to 21f7d28 Compare March 10, 2026 12:21
ec1467 and others added 9 commits March 10, 2026 16:44
@ec1467
chore(web-components): upgrade Stencil to v4.41.1
e6cf145 
Inluding component theme logic fixes and test updates
@ec1467
chore(canary-web-components): upgrade Stencil to v4.41.1
a40c647 
Upgrade @stencil/core to v4.41.1, fix tests, update snaphots. No functional changes.
@ec1467
docs(canary-docs): update docs after Stencil and TypeScript upgrades
1977092
@ec1467
docs(docs): update docs after Stencil and Typescript upgrades
22fe246
@ec1467
chore(react): upgrade TypeScript to v5.3.3
8dccccd
@ec1467
chore(canary-react): upgrade TypeScript to v5.3.3
3b6b4a3
@jd3267 @ec1467
fix(react): update visual regresstion test thresholds for ic-select
5776e04 
update visual regression test thresholds for ic-select
@jd3267 @ec1467
fix(web-components): fix to ic-button theme colour in ic-select and i…
df2dfdb 
…c-search-bar

fix to ic-button theme colour by setting to inherit if not focused in ic-select and ic-search-bar
@GCHQ-Developer-847 @ec1467
test(react): fix side nav test failing after Stencil upgrade
a81d401 
Remove snapshots from controlled collapsed and expanded tests (tried other
solutions but there was still flakiness; all is fine in Storybook). Change
the test data (DynamicExpandedSideNav) slightly to ensure controlled
expansion behaviour is being tested properly.

. #4277
@ec1467 ec1467 force-pushed the 3857-upgrade-stencil branch from 21f7d28 to a81d401 Compare March 10, 2026 16:44
@GCHQ-Developer-530 GCHQ-Developer-530 mentioned this pull request Mar 11, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GCHQ-Developer-112 GCHQ-Developer-112 GCHQ-Developer-112 left review comments

@GCHQ-Developer-299 GCHQ-Developer-299 GCHQ-Developer-299 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@ec1467 ec1467

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ec1467 @GCHQ-Developer-847 @GCHQ-Developer-299 @GCHQ-Developer-112 @jd3267