Send InitRequest on dead WebSocket to trigger on_load#1360
Open
nirben82 wants to merge 1 commit intomesop-dev:mainfrom
Open
Send InitRequest on dead WebSocket to trigger on_load#1360nirben82 wants to merge 1 commit intomesop-dev:mainfrom
nirben82 wants to merge 1 commit intomesop-dev:mainfrom
Conversation
richard-to
requested changes
Mar 15, 2026
Collaborator
richard-to
left a comment
richard-to
left a comment
There was a problem hiding this comment.
Overall looks good to me. Just one question which I left as a comment.
| const isWebSocketDead = | ||
| this.experimentService.websocketsEnabled && | ||
| this.webSocket && | ||
| this.webSocket.readyState !== WebSocket.OPEN; |
Collaborator
There was a problem hiding this comment.
Looks likes websocket ready state has 4 different states (open, opening, close, closing) (https://developer.mozilla.org/en-US/docs/Web/API/WebSocket/readyState).
Should this only occur on close? Or is ok to have for the other three states?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the dispatch method to check if the underlying WebSocket is dead before firing a user event. If it is dead, the client:
Fixes #1359