feat: PlainStateProvider returns key-value pairs with version tracking#117
Open
feat: PlainStateProvider returns key-value pairs with version tracking#117
Conversation
Refactor search functions to support version tracking: - Make shi_search_with_version generic to accept any extra data type - Reuse generic helper in shi_search to eliminate code duplication - Add inline attribute for performance optimization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhance
PlainStateProviderto return version information alongside key-value pairs, enabling downstream consumers to track state changes and implement version-aware caching strategies.Key API Change:
Changes
SaltVersion(u64) for tracking state value versionsStateReader::value_with_version()with backward-compatible default implementationPlainStateProvider::plain_value()now returns(SaltValue, SaltVersion)tuple#[repr(align(8))]toSaltValuefor improved memory alignmentBackward Compatibility
✅ Existing
StateReaderimplementations continue to work without modification - the defaultvalue_with_version()implementation returns version0PlainStateProvider::plain_value()must update to handle the new return type