Skip to content

protocol utils: try known keys first#35

Open
felix-albrecht wants to merge 2 commits intomedusalix:masterfrom
felix-albrecht:protocol-features
Open

protocol utils: try known keys first#35
felix-albrecht wants to merge 2 commits intomedusalix:masterfrom
felix-albrecht:protocol-features

Conversation

@felix-albrecht
Copy link

@felix-albrecht felix-albrecht commented Feb 4, 2026

This PR implements the search for known keys, as suggested by @ThiefMaster (could close #34)
The arrays should contain all the keys that have been dug up so far :)

Also adds arguments for dumping EEPROM and memory.

@medusalix medusalix changed the base branch from protocol-features to master February 8, 2026 18:34
@medusalix
Copy link
Owner

Hi, thanks for the PR. That looks very nice.

I've decided to change the target branch to master, which might have messed up some of your commits (sorry about that).

Could you also move the CLI tools to src/bin/ as part of your PR? I think that would make sense since they're not really examples anymore.

@medusalix medusalix added the enhancement New feature or request label Feb 8, 2026
@felix-albrecht felix-albrecht force-pushed the protocol-features branch 2 times, most recently from 151717d to a9d9fc0 Compare February 9, 2026 09:46
@felix-albrecht
Copy link
Author

I moved the examples to src/bin and added clap as an optional dependency. The CI pipeline runs fine on my fork.
Sorry for the many commits, I had to rebase two times because I hadn't set up signing keys for commits before.

@rchl
Copy link

rchl commented Feb 9, 2026

(if the maintainer is happy there is no reason to listen to me but I would think that ideally the access codes would be collected from all existing implementations dynamically instead of hardcoding separately and needing to keep in sync. But that might require bigger refactor I guess)

@medusalix
Copy link
Owner

I think that's fine for now. I plan on refactoring the device connection/initialization anyway once I implement baud rate switching. So that can wait until then.

@felix-albrecht Could you squash your comments? That would make it a bit easier to review for me.

@medusalix medusalix added this to the v0.2.0 milestone Feb 13, 2026
@felix-albrecht felix-albrecht mentioned this pull request Feb 14, 2026
@felix-albrecht
Copy link
Author

I just removed one x in the print statement for the Software ID, to have it in decimal :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make protocol utils more convenient

3 participants