protocol utils: try known keys first#35
protocol utils: try known keys first#35felix-albrecht wants to merge 2 commits intomedusalix:masterfrom
Conversation
|
Hi, thanks for the PR. That looks very nice. I've decided to change the target branch to Could you also move the CLI tools to |
151717d to
a9d9fc0
Compare
|
I moved the examples to |
|
(if the maintainer is happy there is no reason to listen to me but I would think that ideally the access codes would be collected from all existing implementations dynamically instead of hardcoding separately and needing to keep in sync. But that might require bigger refactor I guess) |
|
I think that's fine for now. I plan on refactoring the device connection/initialization anyway once I implement baud rate switching. So that can wait until then. @felix-albrecht Could you squash your comments? That would make it a bit easier to review for me. |
… optional dependency
57f2043 to
8fc867e
Compare
a29c06b to
429f86a
Compare
|
I just removed one |
This PR implements the search for known keys, as suggested by @ThiefMaster (could close #34)
The arrays should contain all the keys that have been dug up so far :)
Also adds arguments for dumping EEPROM and memory.