perf: improve case-insensitive string compare#77
Merged
mdsteele merged 1 commit intomdsteele:masterfrom Feb 2, 2026
Merged
Conversation
4763549 to
c1f1902
Compare
mdsteele
reviewed
Jan 31, 2026
Owner
mdsteele
left a comment
There was a problem hiding this comment.
Thanks for digging into this!
Contributor
Author
|
Thanks for the review. I can add a benchmark specifically for these calls if you want. But maybe that's a bit too targeted. The main benchmark already shows a huge regression on the ASCII part. Anyway. I will double check the improvement on the non-ascii case as I am also a bit unsure if that change is worth it. -> NO, reverted. |
c1f1902 to
02d565b
Compare
02d565b to
95376fe
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did some performance testing and this was a serious bottleneck for files with large amounts of streams.
master:
this pull request:
I have even more improvements coming but wanted this merged first.