explicitly load libomp.so when required#5
Open
Vipul-Cariappa wants to merge 3 commits intomcbarton:Add-OpenMP-kernelfrom
Open
explicitly load libomp.so when required#5Vipul-Cariappa wants to merge 3 commits intomcbarton:Add-OpenMP-kernelfrom
Vipul-Cariappa wants to merge 3 commits intomcbarton:Add-OpenMP-kernelfrom
Conversation
Author
|
cc @vgvassilev |
mcbarton
reviewed
Jan 13, 2026
Vipul-Cariappa
force-pushed
the
dev/mcbarton/Add-OpenMp-kernel
branch
from
eb6591f to
3909d3a
Compare
vgvassilev
approved these changes
Jan 13, 2026
vgvassilev
left a comment
vgvassilev
left a comment
There was a problem hiding this comment.
Modulo weird coding conventions, lgtm!
Vipul-Cariappa
force-pushed
the
dev/mcbarton/Add-OpenMp-kernel
branch
from
3909d3a to
42415e6
Compare
mcbarton
force-pushed
the
Add-OpenMP-kernel
branch
from
56bb93a to
c805b83
Compare
Vipul-Cariappa
force-pushed
the
dev/mcbarton/Add-OpenMp-kernel
branch
2 times, most recently
from
5f77a23 to
a1c7a3a
Compare
remove the need to set env var PATH & LD_LIBRARY_PATH for omp kernels
Vipul-Cariappa
force-pushed
the
dev/mcbarton/Add-OpenMp-kernel
branch
from
a1c7a3a to
ebb4f8e
Compare
mcbarton
force-pushed
the
Add-OpenMP-kernel
branch
2 times, most recently
from
a889c1b to
f7552c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove the need to set env var
PATH&LD_LIBRARY_PATHfor omp kernelsThis should also let you remove
PATHandLD_LIBRARY_PATHcompletely from the other kernels, too.