Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on the test suite for reduce! You've covered several important cases. However, I am requesting one change to make it fully compliant with the standard.
Your tests are missing a critical edge case: calling reduce on an empty array without providing an initial value. According to the MDN specification, this action is expected to throw a TypeError. Please add a test case to verify this behavior.
You can use Jest's toThrow() matcher to assert this, for example:
expect(() => [].reduce2((acc, val) => acc + val)).toThrow(TypeError);Adding this will ensure your tests are comprehensive. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
|
|
||
| expect(f).not.toHaveBeenCalled(); | ||
| expect(result).toBe(0); | ||
| }); |
There was a problem hiding this comment.
This is a good test for an empty array with an initial value. To fully align with the MDN specification, you should also add a test case for what happens when reduce is called on an empty array without an initial value. That scenario is expected to throw a TypeError.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this! Your custom reduce implementation is solid and correctly handles the required edge cases. You've successfully addressed the feedback by adding the test case for the TypeError when reduce is called on an empty array without an initial value. Your test suite is now comprehensive and meets all requirements, so I am approving your submission. Well done!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.