js_array_reverse by Alex-redman · Pull Request #167 · mate-academy/js_array_reverse

Alex-redman · 2025-10-02T15:16:49Z

No description provided.

mateacademy-ai-mentor

Review Summary

Your Jest tests cover many essentials (function existence, return type, empty inputs, single/multi-element cases), but a few critical requirements are missing from the task specification. Specifically, the tests must include the exact example cases: ['Hell0'] -> ['0lleH'] and ['I','am','a','student!'] -> ['!','tn','e','dutsamaI'] (add these to src/arrayReverse.test.js near your other example checks). Also add an explicit length-1 string case and a test to ensure the input array is not mutated (immutability). For example, copy the input before calling arrayReverse and assert input remains equal to the copy. These changes ensure coverage of digits/special symbols and document the expected behavior precisely. Finally, confirm src/arrayReverse.js exists and exports arrayReverse so the new tests run. Great work so far—add these required tests and we’ll be good to approve.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2025-10-02T15:20:39Z

src/arrayReverse.test.js


-  it(`should return an empty string
-    if original array consists of an empty string`, () => {
+  it('should return an array with reversed strings', () => {


Add the exact multi-element example required by the task description to ensure redistribution across multiple very-short strings and special symbols is covered. For example:

expect(arrayReverse(['I', 'am', 'a', 'student!'])).toEqual(['!', 'tn', 'e', 'dutsamaI']);

This verifies length-1 behaviour and special-symbol handling as specified in the description.

mateacademy-ai-mentor · 2025-10-02T15:20:39Z

src/arrayReverse.test.js

+
+  it('should return an array with a single reversed string', () => {
+    expect(arrayReverse(['Mate'])).toEqual(['etaM']);
+  });


Add the single-string example from the description that includes a digit. For example:

expect(arrayReverse(['Hell0'])).toEqual(['0lleH']);

This directly matches the specification and ensures numbers inside strings are handled correctly.

mateacademy-ai-mentor · 2025-10-02T15:20:40Z

src/arrayReverse.test.js

+    expect(arrayReverse(['', ''])).toEqual(['', '']);
+  });
+
+  it('should return an array with a single reversed string', () => {


Add an explicit test for very-short (length-1) strings if you want a dedicated check (the multi-element example above covers it, but an explicit test makes intent clear). Example:

expect(arrayReverse(['a'])).toEqual(['a']); expect(arrayReverse(['x','y'])).toEqual(['y','x']); // or other short combinations

This ensures the function handles minimal-length strings as required.

mateacademy-ai-mentor · 2025-10-02T15:20:40Z

src/arrayReverse.test.js

  });

-  // write more tests here
+  it('should preserve original array length', () => {


Add a test to assert the original input array is not mutated (immutability). For example:

const input = ['Mate', 'Academy']; const copy = [...input]; arrayReverse(input); expect(input).toEqual(copy);

This ensures tests don't rely on in-place mutation and documents expected behaviour.

mateacademy-ai-mentor

Review Summary

Decision: REQUEST_CHANGES

Your test file src/arrayReverse.test.js is strong and covers the required examples and edge cases well. However, there is a critical blocker: the tests require('./arrayReverse') (see src/arrayReverse.test.js top import), but no src/arrayReverse.js implementation was provided in the submission. Without this file exporting the function (e.g., module.exports = arrayReverse), Jest will fail to load the module and all tests will error out rather than validate behavior.

Required fixes:

Ensure src/arrayReverse.js exists and exports the function as module.exports = arrayReverse so that require('./arrayReverse') in the test resolves correctly.

Nice-to-have (not required to pass):

Add an immutability test near the single-string cases to confirm the input array isn’t mutated.

Once the implementation file is added with the correct export, the test suite should run as intended. Great job on the comprehensive test coverage and clear example assertions!

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2025-10-02T15:29:41Z

src/arrayReverse.test.js


-describe(`Function 'arrayReverse':`, () => {
-  const arrayReverse = require('./arrayReverse');
+const arrayReverse = require('./arrayReverse');


This file requires the implementation with require('./arrayReverse'). Make sure src/arrayReverse.js exists at that path and exports the function (e.g. module.exports = arrayReverse). If the file is missing or exported under a different name/path the tests will fail to load the module.

mateacademy-ai-mentor · 2025-10-02T15:29:41Z

src/arrayReverse.test.js

+  });
+
+  it("should handle ['Hell0'] -> ['0lleH']", () => {
+    expect(arrayReverse(['Hell0'])).toEqual(['0lleH']);


Good — the single-item example with digits is present and asserts the exact expected output from the description (['Hell0'] -> ['0lleH']). This satisfies the requirement to test strings containing numbers along with letters.

mateacademy-ai-mentor · 2025-10-02T15:29:41Z

src/arrayReverse.test.js

+    expect(arrayReverse(['', ''])).toEqual(['', '']);
+  });
+
+  it('should return an array with a single reversed string', () => {


Suggestion: add an immutability test to ensure the input array is not mutated by arrayReverse. For example, copy the input before calling the function and assert the original equals the copy afterwards. Place this test near the single-string tests so behavior is clearly documented (not required by the description but recommended).

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
_{[CODE: NCM]}

If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
_{[CODE: NCM]}

If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
_{[CODE: NCM]}

If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
_{[CODE: NCM]}

If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.

etojeDenys

good job

add tests for arrayReverse function

395b221

mateacademy-ai-mentor suggested changes Oct 2, 2025

View reviewed changes

update tests

cc3afed

Alex-redman requested a review from mateacademy-ai-mentor October 2, 2025 15:26

mateacademy-ai-mentor suggested changes Oct 2, 2025

View reviewed changes

Alex-redman requested a review from mateacademy-ai-mentor October 2, 2025 15:32

mateacademy-ai-mentor reviewed Oct 2, 2025

View reviewed changes

etojeDenys approved these changes Oct 4, 2025

View reviewed changes

Conversation

Alex-redman commented Oct 2, 2025

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

mateacademy-ai-mentor Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

mateacademy-ai-mentor Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Uh oh!

etojeDenys left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants