MLE-27077 Reverting recent changes to Jenkinsfile#1901
Conversation
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull request overview
Reverts recent Jenkins pipeline and docker-compose adjustments to restore a passing regression pipeline.
Changes:
- Simplifies Jenkinsfile by removing ARM-specific logic/stages and related environment variables.
- Hard-codes MarkLogic docker-compose platform and converter install flag.
- Adjusts MarkLogic startup/test sequence in the pipeline.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docker-compose.yaml | Reverts env-driven configuration back to fixed platform and converter settings. |
| Jenkinsfile | Reverts ARM handling/infrastructure stages and reworks MarkLogic bring-up steps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| sleep 3 | ||
| ./gradlew -i mlWaitTillReady |
There was a problem hiding this comment.
mlWaitTillReady is executed twice with a fixed sleep in between. This adds unnecessary time to every run and can mask timing issues. Consider running mlWaitTillReady once (or rely on its own retry/backoff) and remove the extra sleep unless there’s a specific, documented reason to keep both.
| sleep 3 | |
| ./gradlew -i mlWaitTillReady |
| platform: linux/amd64 | ||
| environment: | ||
| - INSTALL_CONVERTERS=${MARKLOGIC_INSTALL_CONVERTERS:-true} | ||
| - INSTALL_CONVERTERS=true |
There was a problem hiding this comment.
These changes remove the ability to override platform and converter installation via environment variables (previously supported via PLATFORM and MARKLOGIC_INSTALL_CONVERTERS). If any CI jobs or developer workflows relied on overriding these values, this is a breaking behavior change. Consider restoring env-driven defaults (e.g., using variable expansion with fallbacks) while keeping the same default behavior.
2 participants
Regression jobs are failing, so reverting both the fix I tried and the original changes to try to get back to a green state.