Skip to content

Avoid lazy initialization of Mutex#132

Open
olleolleolle wants to merge 1 commit intomarcmo:masterfrom
olleolleolle:patch-1
Open

Avoid lazy initialization of Mutex#132
olleolleolle wants to merge 1 commit intomarcmo:masterfrom
olleolleolle:patch-1

Conversation

@olleolleolle
Copy link

@olleolleolle olleolleolle commented Apr 3, 2020

This PR moves the creation of the Mutex to the constructor.

  • The class needs it all the time for its primary tasks
  • This change helps Ruby platforms which do not have a GIL/GVL

Hope this helps!

  - The class needs it all the time for its primary tasks
  - This change helps Ruby platforms which do not have a GIL/GVL
@olleolleolle
Copy link
Author

cc @ioquatix

@ioquatix
Copy link

ioquatix commented Apr 4, 2020

Nice work!

@gizmomogwai
Copy link
Collaborator

gizmomogwai commented Apr 4, 2020

is this some kind of bot code improvement @olleolleolle?
it looks good for sure!

@olleolleolle
Copy link
Author

No bots involved! Glad you like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants