Skip to content

Add .exe for Windows targets. Fixes mailgun/godebug#72. #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DHowett wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add .exe for Windows targets. Fixes mailgun/godebug#72. #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,12 @@ func doBuild(args []string) {
goArgs = mapToTmpDir(tmpDir, goArgs)
}

bin := filepath.Base(strings.TrimSuffix(goArgs[0], ".go")) + ".debug"
exeSuffix := ""
Copy link

@ramonkeypr ramonkeypr Apr 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about binSuffix so that we can leave the code open to other executable binary file extensions that go may produce in the future?

if conf.Build.GOOS == "windows" {
exeSuffix = ".exe"
}

bin := filepath.Base(strings.TrimSuffix(goArgs[0], ".go")) + ".debug" + exeSuffix
if *o != "" {
bin = *o
}
Expand Down