Migrate in-store-pickup email to strict mode #3385
Open
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@magento run all tests |
engcom-Hotel
requested changes
Jan 29, 2026
Collaborator
engcom-Hotel
left a comment
engcom-Hotel
left a comment
There was a problem hiding this comment.
Hello @smartexcan,
Thank you for the collaboration!
The changes seems good to us, but please refer to the below review comments:
- Cover the PR changes with some automated test in accordance to the DOD
- Sign the CLA so that we can move forward with this PR
Thank you
engcom-Hotel
moved this from Ready for Review
to Changes Requested
in Inventory - Pull Request Progress
engcom-Hotel
added
Progress: needs update
and removed
Progress: ready for review
labels
Author
|
updated the branch and bot is reporting signed now lol I don't know how to write tests for this, but I've been using this fix in our production deployment since i filed the PR and it working as expected. also had a misclick on the re-review thing... |
Author
|
@magento run all tests |
Author
|
@magento run Static Tests, Unit Tests |
engcom-Hotel
approved these changes
Jan 30, 2026
Collaborator
engcom-Hotel
left a comment
engcom-Hotel
left a comment
There was a problem hiding this comment.
Approving this PR for further processing
engcom-Hotel
moved this from Changes Requested
to Reviewer Approved
in Inventory - Pull Request Progress
engcom-Hotel
added
Progress: approved
Progress: ready for testing
and removed
Progress: needs update
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
The In Store Pickup "Ready for pickup" notification email still used deprecated (and removed as of magento 2.4.4) variables with direct method calls.
This resulted in the affected variables in the email template not being rendered.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)