feat: Add generic type support to Parameter classes #475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds generic type support to gokart's custom Parameter classes, following the same approach as Luigi's PR #3369. The base
Paramerclass and several specialized parameter classes now use Python'sGenerictype to provide better type hints and IDE support.Key changes:
TaskInstanceParametergeneric withTaskInstanceParameter[TaskOnKartType]ListTaskInstanceParametergeneric withListTaskInstanceParameter[TaskOnKartType]SerializableParameterto inherit fromParameter[S]ZonedDateSecondParameterto inherit fromParameter[datetime.datetime]TypeVarforTaskOnKartTypeto maintain type safety across task instancesMotivation and Context
This change improves the developer experience when using gokart by p
viding:
By leveraging Luigi's generic type support (introduced in spotify/luigi#3369), gokart can now provide even stronger type guarantees for its custom parameter types, particularly
TaskInstanceParameterwhich is heavily used for task dependencies.This enhancement helps catch type-related bugs earlier in the development process and makes the codebase more maintainable.