Removed extends Drag, not compatible with Dart 3 & Flutter 3.10#104
Open
litang0908 wants to merge 1 commit intolykhonis:masterfrom
Open
Removed extends Drag, not compatible with Dart 3 & Flutter 3.10#104litang0908 wants to merge 1 commit intolykhonis:masterfrom
litang0908 wants to merge 1 commit intolykhonis:masterfrom
Conversation
|
I can confirm that this PR is working, and I strongly advise @lykhonis to merge this PR ASAP, as image_crop is breaking compatibility in many production apps... |
|
please merge this branch, this issue is causing errors in production apps |
|
@lykhonis look this pr please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CropState extends both State and Drag, but Dart 3 & Flutter 3.10, the class 'Drag' can't be used as a mixin because it's neither a mixin class nor a mixin.