Updated description of configuration file location#666
Open
dvdnglnd wants to merge 1 commit intolumifyio:developfrom
Open
Updated description of configuration file location#666dvdnglnd wants to merge 1 commit intolumifyio:developfrom
dvdnglnd wants to merge 1 commit intolumifyio:developfrom
Conversation
The locations specified didn't mention that `io.lumify.core.config.FileConfigurationLoader` will actually look for a `config` directory in each of the locations. It took me a few minutes of looking at source to figure out I couldn't do `c:/opt/lumify/lumify.properties` but needed to do `c:/opt/lumify/config/lumify.properties`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The locations specified didn't mention that
io.lumify.core.config.FileConfigurationLoaderwill actually look for aconfigdirectory in each of the locations. It took me a few minutes of looking at source to figure out I couldn't doc:/opt/lumify/lumify.propertiesbut needed to doc:/opt/lumify/config/lumify.properties.