[rescue] Support erasing both slots in rescue mode #29197
+186
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the `TEST_OWNER_CONFIGS` in the `rom_ext` BUILD file to use the virtual slot linker script and the corresponding dice x509 imm_section. This allows for more flexible slot assignment during testing. Change-Id: I319ed9e559e4ed034fea2bddde96b15768e70e4e Signed-off-by: Yi-Hsuan Deng <yhdeng@google.com>
sasdf
force-pushed
the
mgT2644fe4c
branch
4 times, most recently
from
e126612 to
54199ed
Compare
This change introduces a new bit in the rescue configuration's `size` field to indicate whether the rescue region should be erased in both flash slots. When `EraseBoth` (bit 15) is set, the rescue protocol will erase the specified page range in both Bank 0 and Bank 1, regardless of which slot is currently being targeted for rescue. Change-Id: I2644fe4c4ce21a7b36086cef2e54885062d70ff7 Signed-off-by: Yi-Hsuan Deng <yhdeng@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new bit flag in the rescue configuration's
sizefield to indicate whether the rescue region should be erased in both flash slots/banks.Since the rescue config is not expandable and there's no reserved words, I repurpose the MSB of the rescue region size field for this bit flag.
When
EraseBoth(bit 15) is set, the rescue protocol will erase the specified page range in both Bank 0 and Bank 1, regardless of which slot is currently being targeted for rescue. If the recuse target is ROM_EXT, it will erase both configured ranges plus the inactive ROM_EXT slot.This change costs 56 bytes in ROM_EXT.