Skip to content

Conversation

@steffyP
Copy link
Member

@steffyP steffyP commented Jan 26, 2026

This PR fixes the basic localstack setup functionalities by the setup-localstack action.

  • fix issue with referencing the GH_ACTION_VERSION using github.head_ref that caused problems for branch-names containing/

  • clean up + fix of the CI tests in .github/workflows/ci.yml:

    • Test LocalStack Version - installs an older version of LS, including the use of the old env LOCALSTACK_API_KEY
    • Test Cloud Pods Action + Test Loading Cloud Pod:
      • creates and uploads a cloud pod (with a random id)
      • then starts a new localstack instance injecting the cloud pod
      • verifies the content was loaded
      • deletes the pod from remote
    • Test Local State Save Action + Test Local State Load Action:
      • exports the state locally (uploaded as artifact),
      • and imports the state in a new instance
      • verifies the resources are available
  • temporarly deactivate the CI tests in .github/workflows/ephemeral.yml

    • tests are not working, and as it turned out the API for ephemeral instances is currently unstable
    • will try to improve the action itself in a follow-up PR to see if re-tries/waits makes it more stable and then re-check the CI tests

@steffyP steffyP marked this pull request as ready for review January 26, 2026 17:19
@steffyP
Copy link
Member Author

steffyP commented Jan 26, 2026

FYI: I'm breaking down the cleanup initiative started in #56 into smaller pieces.

Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks so much for stabilizing the pipeline, hardening it, and investigating on the ephemeral instance issues! Breaking things up to have small individual PRs is also a great idea given that there might be more to do here to fully clean everything up! 💯 🦸🏽 🧹

env:
LOCALSTACK_API_KEY: ${{ secrets.LOCALSTACK_API_KEY }}
GH_ACTION_VERSION: ${{ github.event_name == 'pull_request' && github.head_ref || github.ref_name }}
LOCALSTACK_AUTH_TOKEN: ${{ secrets.LOCALSTACK_API_KEY }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit / out of scope: Since we are at it we could also update the secrets names. I created a secret called LOCALSTACK_AUTH_TOKEN which we could use here directly. If refers to the same CI auth token (i.e. it has the same content than LOCALSTACK_API_KEY).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks 😄
i will update the secret in a follow-up PR, already prepared a commit that removes the usage of LOCALSTACK_API_KEY envs

@steffyP steffyP merged commit 5506b9b into main Jan 27, 2026
5 checks passed
@steffyP steffyP deleted the fix_ci branch January 27, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants