Fix most unit tests and the conformance test runner.#64
Open
danvk wants to merge 1 commit intolloyd:masterfrom
Open
Fix most unit tests and the conformance test runner.#64danvk wants to merge 1 commit intolloyd:masterfrom
danvk wants to merge 1 commit intolloyd:masterfrom
Conversation
|
Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion. src/test/parse_test.html, line 86 at r1 (raw file):
Comments from Reviewable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the "unit" tests to be tremendously helpful while building pyjsonselect.
Most of them were broken. This PR doesn't fix all of them, but it does fix most:
parse_test.html: 1 tests of 26 passed, 25 failed. → 21 tests of 26 passed, 5 failed. (+20 passes!)lex_test.html: 21 tests of 28 passed, 7 failed. (unchanged)match_test.html: 13 tests of 13 passed, 0 failed. (unchanged)conformance_test.html: JavaScript error on page → 47 tests of 47 passed, 0 failed. (+47 passes!)