-
Notifications
You must be signed in to change notification settings - Fork 124
Introduce Private Link Protocol #1401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| message ClientSettingsRequest { | ||
| } | ||
|
|
||
| message PrivateLink { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be associated with the livekit project as an additional safeguard to prevent assigning a private link to a different project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrmm I had assumed that project was part of the request context (because I didn't see project/project_id elsewhere in this file).
Yes 100% it will be associated, let me verify if that should exist on the messages or if it's part of the request context (in headers or w/e)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, this is the request message. You are right that project_id is coming from API key.
cfa26df to
3919bbc
Compare
d6712ca to
3fb1f79
Compare
7012e66 to
23b3db2
Compare
1c65704 to
bc49e56
Compare
8fa1284 to
f5d08f0
Compare
791e570 to
915b702
Compare
This introduces a protocol for private link connections from hosted agents