Skip to content

Conversation

@keepingitneil
Copy link
Contributor

This introduces a protocol for private link connections from hosted agents

@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2026

⚠️ No Changeset found

Latest commit: abbf2e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

message ClientSettingsRequest {
}

message PrivateLink {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be associated with the livekit project as an additional safeguard to prevent assigning a private link to a different project?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrmm I had assumed that project was part of the request context (because I didn't see project/project_id elsewhere in this file).

Yes 100% it will be associated, let me verify if that should exist on the messages or if it's part of the request context (in headers or w/e)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, this is the request message. You are right that project_id is coming from API key.

@keepingitneil keepingitneil marked this pull request as ready for review February 9, 2026 16:43
@keepingitneil keepingitneil changed the title [WIP] Introduce Private Link Protocol Introduce Private Link Protocol Feb 9, 2026
@keepingitneil keepingitneil merged commit c098782 into main Feb 9, 2026
5 checks passed
@keepingitneil keepingitneil deleted the neil/private-link branch February 9, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants