refactor(webauthn): remove private methods with underscore prefix#179
Open
AlfioEmanueleFresta wants to merge 10 commits intomasterfrom
Open
refactor(webauthn): remove private methods with underscore prefix#179AlfioEmanueleFresta wants to merge 10 commits intomasterfrom
AlfioEmanueleFresta wants to merge 10 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the WebAuthn API surface by removing internal _-prefixed methods from the public WebAuthn trait and re-homing their logic into module-private free functions, leaving only webauthn_make_credential and webauthn_get_assertion as the public trait methods.
Changes:
- Removes
_webauthn_*and_negotiate_protocolmethods from the publicWebAuthntrait. - Introduces module-private helper functions (
make_credential_*,get_assertion_*,negotiate_protocol) and routes the public trait methods through them. - Keeps the existing protocol negotiation + FIDO2/U2F branching behavior in the blanket
impl<C: Channel> WebAuthn for C.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AlfioEmanueleFresta
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: move internal
_-prefixed methods out of the publicWebAuthntrait, and into module-private free functions. Keeping onlywebauthn_make_credentialandwebauthn_get_assertionin the public WebAuthn API surface.No behaviour changes.