Skip to content

xilem_web: Fix clippy::multiple_bound_locations lints.#216

Merged
waywardmonkeys merged 1 commit intolinebender:mainfrom
waywardmonkeys:multiple-bound-locations-lint
Apr 26, 2024
Merged

xilem_web: Fix clippy::multiple_bound_locations lints.#216
waywardmonkeys merged 1 commit intolinebender:mainfrom
waywardmonkeys:multiple-bound-locations-lint

Conversation

@waywardmonkeys
Copy link
Contributor

Define generic bounds once rather than partly in the bound predicate and partly in the where clause.

Copy link
Member

@Philipp-M Philipp-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I have strong feelings about this, but I've put the bounds in the where clause already in #197 (here), I think having them in one place (where ...) would be better?

@waywardmonkeys
Copy link
Contributor Author

I tired that! But apparently ?Sized couldn’t be there … will repro later and make sure I didn’t do something dumb.

Define generic bounds once rather than partly in the
bound predicate and partly in the `where` clause.
@waywardmonkeys waywardmonkeys force-pushed the multiple-bound-locations-lint branch from 4571661 to 041b0c1 Compare April 26, 2024 16:04
@waywardmonkeys
Copy link
Contributor Author

@Philipp-M So, I'd done something dumb earlier when I got an error. I've updated the PR per your suggestion (and added one case that the lint didn't catch for the impl block).

Copy link
Member

@Philipp-M Philipp-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Apr 26, 2024
Merged via the queue into linebender:main with commit 0a08541 Apr 26, 2024
@waywardmonkeys waywardmonkeys deleted the multiple-bound-locations-lint branch April 26, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants