Allow build processors using kafka-clients Deserializer#267
Merged
kawamuray merged 5 commits intoline:masterfrom Sep 17, 2025
Merged
Allow build processors using kafka-clients Deserializer#267kawamuray merged 5 commits intoline:masterfrom
kawamuray merged 5 commits intoline:masterfrom
Conversation
ocadaruma
force-pushed
the
custom-deserializer
branch
from
460deb8 to
10e39f9
Compare
ocadaruma
changed the title
ocadaruma
force-pushed
the
custom-deserializer
branch
from
10e39f9 to
0e3a42b
Compare
ocadaruma
force-pushed
the
custom-deserializer
branch
from
0e3a42b to
f868c6d
Compare
ocadaruma
force-pushed
the
custom-deserializer
branch
2 times, most recently
from
fa25a55 to
233b813
Compare
ocadaruma
force-pushed
the
custom-deserializer
branch
from
233b813 to
f54d38c
Compare
kawamuray
approved these changes
Sep 17, 2025
| consumeManager.close(); | ||
| quotaApplier.close(); | ||
| metrics.close(); | ||
| processors.close(); |
Contributor
There was a problem hiding this comment.
hm, should we surround these close calls and log failure one-by-one?
Member
Author
There was a problem hiding this comment.
Ah, that might be good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Summary of changes
ProcessorsBuilder#consumingnow have an overload that acceptskafka.common.serialization.Deserializer<T>, which can be used to deserialize tasks using topic, record headers and custom TaskMetadata extraction logic is not necessary