LSPS2: Add support for ongoing proportional fees#3846
Closed
aylagreystone wants to merge 1 commit intolightningdevkit:mainfrom
Closed
LSPS2: Add support for ongoing proportional fees#3846aylagreystone wants to merge 1 commit intolightningdevkit:mainfrom
aylagreystone wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
|
👋 Hi! I see this is a draft PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3846 +/- ##
==========================================
- Coverage 89.88% 89.82% -0.06%
==========================================
Files 162 162
Lines 130415 130420 +5
Branches 130415 130420 +5
==========================================
- Hits 117217 117145 -72
- Misses 10509 10576 +67
- Partials 2689 2699 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for ongoing proportional fee proposal for bLIP52 lightning/blips#63
Still waiting for more feedback on the bLIP change but having it implemented in at least one implementation seems to be a requirement for merge so preparing one for LDK.