Conversation
|
|
||
| includes = [] | ||
| includes.extend(glib_includes) | ||
| includes.extend(["/usr/local/include"]) |
There was a problem hiding this comment.
Hardcoding this path doesn't look right to me
There was a problem hiding this comment.
do you have any better idea? I am not familiar with this build system and just adding the default installation path should not hurt.
There was a problem hiding this comment.
Normally you want to detect the path that's required based on dependencies. I don't know anything about the python build system though. /cc @Wenzel
|
hi @bentau, glib is already included in the build via I suppose your glib is installed in Try this on the command line: for me it yields the following output You need to tell pkg config how to find the |
|
There were two problems:
|
|
@bentau they were two problems, meaning that you solved them now ? |
|
both things are actually fixed by the PR. However, the second problem was not fixed very nicely by just adding a hardcoded path. If you think those patches are not required you can close it. |
|
@bentau by installing the latest Libvmi, I can repro a compilation error linked to a glib missing. I cannot pin point which commit broke libvmi-python bindings, but I applied your fix in this PR: Thank you for letting me know about this issue ! |
My compiler does not want to build without having glib.h included