feat(swarm): introduce ConnectionId::new_unchecked constructor#3652
Merged
mergify[bot] merged 7 commits intomasterfrom Mar 21, 2023
Merged
feat(swarm): introduce ConnectionId::new_unchecked constructor#3652mergify[bot] merged 7 commits intomasterfrom
ConnectionId::new_unchecked constructor#3652mergify[bot] merged 7 commits intomasterfrom
Conversation
Contributor
Author
|
I am going to directly release this after it merges to unblock @melekes. This is trivial in my eyes, hence I am merging this right away. |
Contributor
|
This pull request has merge conflicts. Could you please resolve them @thomaseizinger? 🙏 |
mxinden
reviewed
Mar 22, 2023
Contributor
|
@thomaseizinger @mxinden what is the timeline for the next patch release (0.51.2)? we're (Parity) interested in this change specifically. I can create a PR if necessary. |
Member
|
I will try tomorrow. No promises @melekes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
In earlier iterations of the design for generic connection management, we removed the
ConnectionId::newconstructor because it would have allowed users to createConnectionIds that are already taken, thus breaking invariants thatNetworkBehaviours rely on. Later, we incorporated the creation ofConnectionIdinDialOptswhich mitigates this risk altogether.Thus, it is reasonably safe to introduce a public, non-deprecated constructor for
ConnectionIdthat can be used for tests.Related #3327 (comment).
Notes & open questions
cc @melekes
Change checklist