Skip to content

Conversation

@KBorm
Copy link
Contributor

@KBorm KBorm commented Feb 10, 2026

Note: Please fill out all relevant sections and remove irrelevant ones.

🔀 Purpose of this PR:

  • Fixes a bug
  • Updates for a new Moodle version
  • Adds a new feature of functionality
  • [x ] Improves or enhances existing features
  • Refactoring: restructures code for better performance or maintainability
  • Testing: add missing or improve existing tests
  • Miscellaneous: code cleaning (without functional changes), documentation, configuration, ...

📝 Description:

Please describe the purpose of this PR in a few sentences.

  • What feature or bug does it address?
    In case of a missing subplugin (might occur after update of lifecycle plugin when having custom subplugins???),
    the workflow table crashes.

  • Why is this change or addition necessary?

Software should be robust

  • What is the expected behavior after the change?

No change for running systems


📋 Checklist

Please confirm the following (check all that apply):

  • I have phpunit and/or behat tests that cover my changes or additions.
  • Code passes the code checker without errors and warnings.
  • [x ] Code passes the moodle-ci/cd pipeline on all supported Moodle versions or the ones the plugin supports.
  • Code does not have var_dump() or var_export or any other debugging statements (or commented out code) that
    should not appear on the productive branch.
  • Code only uses language strings instead of hard-coded strings.
  • If there are changes in the database: I updated/created the necessary upgrade steps in db/upgrade.php and
    updated the version.php.
  • If there are changes in javascript: I build new .min files with the grunt amd command.
  • If it is a Moodle update PR: I read the release notes, updated the version.php and the CHANGES.md.
    I ran all tests thoroughly checking for errors. I checked if bootstrap had any changes/deprecations that require
    changes in the plugins UI.

🔍 Related Issues

  • Related to #[IssueNumber]

🧾📸🌐 Additional Information (like screenshots, documentation, links, etc.)

Any other relevant information.

You can check the original code by renameing a subplugin so that it cannot be found


@KBorm
Copy link
Contributor Author

KBorm commented Feb 10, 2026

sorry, this pull request also contains files for another pull request. So have to close it and redo the pull request....

@KBorm KBorm closed this Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant