New bloc-related lints

packages/leancode_lint/README.md

@@ -413,6 +413,203 @@ class MyWidget extends StatelessWidget {
 
 None
 
+### `bloc_class_modifiers`
+
+**DO** add `final` or `sealed` modifiers to bloc state, event, and presentation event classes.
+
+**BAD:**
+
+```dart
+class MyState {}
+
+class MyStateInitial extends MyState {}
+
+class MyStateLoading extends MyState {}
+```
+
+**GOOD:**
+
+```dart
+sealed class MyState {}
+
+final class MyStateInitial extends MyState {}
+
+final class MyStateLoading extends MyState {}
+```
+
+#### Configuration
+
+None.
+
+### `bloc_const_constructors`
+
+**DO** define unnamed const constructors for bloc state, event, and presentation event classes.
+
+**BAD:**
+
+```dart
+class MyState {}
+```
+
+**BAD:**
+
+```dart
+class MyState {
+  MyState();
+}
+```
+
+**GOOD:**
+
+```dart
+class MyState {
+  const MyState();
+}
+```
+
+#### Configuration
+
+None.
+
+### `bloc_related_classes_equatable`
+
+**DO** mix in `EquatableMixin` in bloc state, event, and presentation event classes.
+
+**BAD:**
+
+```dart
+class MyState {
+  MyState(this.value);
+
+  final int value;
+}
+```
+
+**GOOD:**
+
+```dart
+import 'package:equatable/equatable.dart';
+
+class MyState with EquatableMixin {
+  const MyState(this.value);
+
+  final int value;
+
+  @override
+  List<Object?> get props => [value];
+}
+```
+
+#### Configuration
+
+None.
+
+### `bloc_related_class_naming`
+
+**DO** prefix bloc state, event, and presentation event classes with the name of the bloc.
+
+**BAD:**
+
+```dart
+class MyAwesomeBloc extends Bloc<WrongEvent, SomeState> {
+  // ...
+}
+
+class WrongEvent {}
+
+class SomeState {}
+```
+
+**GOOD:**
+
+```dart
+class MyAwesomeBloc extends Bloc<MyAwesomeEvent, MyAwesomeState> {
+  // ...
+}
+
+class MyAwesomeEvent {}
+
+class MyAwesomeState {}
+```
+
+#### Configuration
+
+None.
+
+### `bloc_subclasses_naming`
+
+**DO** prefix bloc state, event and presentation event subclasses with the name of the base class.
+
+**BAD:**
+
+```dart
+class MyAwesomeBloc extends Bloc<MyAwesomeEvent, MyAwesomeState> {
+  // ...
+}
+
+sealed class MyAwesomeState {}
+
+final class SomeState extends MyAwesomeState {}
+
+final class AnotherState extends MyAwesomeState {}
+```
+
+**GOOD:**
+
+```dart
+class MyAwesomeBloc extends Bloc<MyAwesomeEvent, MyAwesomeState> {
+  // ...
+}
+
+sealed class MyAwesomeState {}
+
+final class MyAwesomeStateInitial extends MyAwesomeState {}
+
+final class MyAwesomeStateLoading extends MyAwesomeState {}
+```
+
+#### Configuration
+
+None.
+
+### `prefer_equatable_mixin`
+
+**DO** mix in `EquatableMixin` instead of extending `Equatable`.
+
+**BAD:**
+
+```dart
+import 'package:equatable/equatable.dart';
+
+class Foobar extends Equatable {
+  const Foobar(this.value);
+
+  final int value;
+
+  @override
+  List<Object?> get props => [value];
+}
+```
+
+**GOOD:**
+
+```dart
+import 'package:equatable/equatable.dart';
+
+class Foobar with EquatableMixin {
+  const Foobar(this.value);
+
+  final int value;
+
+  @override
+  List<Object?> get props => [value];
+}
+```
+
+#### Configuration
+
+None.
+
 ## Assists
 
 Assists are IDE refactorings not related to a particular issue. They can be triggered by placing your cursor over a relevant piece of code and opening the code actions dialog. For instance, in VSCode this is done with <kbd>ctrl</kbd>+<kbd>.</kbd> or <kbd>⌘</kbd>+<kbd>.</kbd>.

packages/leancode_lint/lib/assists/convert_iterable_map_to_collection_for.dart

@@ -1,6 +1,7 @@
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/source/source_range.dart';
 import 'package:custom_lint_builder/custom_lint_builder.dart';
+import 'package:leancode_lint/common_type_checkers.dart';
 import 'package:leancode_lint/helpers.dart';
 
 /// Converts an iterable call to [Iterable.map] with an optional
@@ -39,8 +40,6 @@ class ConvertIterableMapToCollectionFor extends DartAssist {
   }
 
   void _handleIterable(MethodInvocation node, ChangeReporter reporter) {
-    const iterableChecker = TypeChecker.fromUrl('dart:core#Iterable');
-
     if (node case MethodInvocation(
       target: Expression(
         staticType: final targetType?,
@@ -57,7 +56,7 @@ class ConvertIterableMapToCollectionFor extends DartAssist {
           ),
         ],
       ),
-    ) when iterableChecker.isAssignableFromType(targetType)) {
+    ) when TypeCheckers.iterable.isAssignableFromType(targetType)) {
       final expression = maybeGetSingleReturnExpression(functionBody);
       if (expression == null) {
         return;

packages/leancode_lint/lib/common_type_checkers.dart

@@ -0,0 +1,75 @@
+import 'package:custom_lint_builder/custom_lint_builder.dart';
+
+extension TypeCheckers on Never {
+  // dart
+  static const iterable = TypeChecker.fromUrl('dart:core#Iterable');
+
+  // equatable
+  static const equatable = TypeChecker.fromName(
+    'Equatable',
+    packageName: 'equatable',
+  );
+  static const equatableMixin = TypeChecker.fromName(
+    'EquatableMixin',
+    packageName: 'equatable',
+  );
+
+  // flutter
+  static const statelessWidget = TypeChecker.fromName(
+    'StatelessWidget',
+    packageName: 'flutter',
+  );
+  static const state = TypeChecker.fromName('State', packageName: 'flutter');
+  static const column = TypeChecker.fromName('Column', packageName: 'flutter');
+  static const row = TypeChecker.fromName('Row', packageName: 'flutter');
+  static const wrap = TypeChecker.fromName('Wrap', packageName: 'flutter');
+  static const flex = TypeChecker.fromName('Flex', packageName: 'flutter');
+  static const sliverList = TypeChecker.fromName(
+    'SliverList',
+    packageName: 'flutter',
+  );
+  static const sliverMainAxisGroup = TypeChecker.fromName(
+    'SliverMainAxisGroup',
+    packageName: 'flutter',
+  );
+  static const sliverCrossAxisGroup = TypeChecker.fromName(
+    'SliverCrossAxisGroup',
+    packageName: 'flutter',
+  );
+  static const sliverChildListDelegate = TypeChecker.fromName(
+    'SliverChildListDelegate',
+    packageName: 'flutter',
+  );
+
+  static const multiSliver = TypeChecker.fromName(
+    'MultiSliver',
+    packageName: 'sliver_tools',
+  );
+
+  // hooks
+  static const hookWidget = TypeChecker.fromName(
+    'HookWidget',
+    packageName: 'flutter_hooks',
+  );
+  static const hookBuilder = TypeChecker.fromName(
+    'HookBuilder',
+    packageName: 'flutter_hooks',
+  );
+  static const hookConsumer = TypeChecker.fromName(
+    'HookConsumer',
+    packageName: 'hooks_riverpod',
+  );
+  static const hookConsumerWidget = TypeChecker.fromName(
+    'HookConsumerWidget',
+    packageName: 'hooks_riverpod',
+  );
+
+  // bloc
+  static const cubit = TypeChecker.fromName('Cubit', packageName: 'bloc');
+  static const bloc = TypeChecker.fromName('Bloc', packageName: 'bloc');
+  static const blocBase = TypeChecker.fromName('BlocBase', packageName: 'bloc');
+  static const blocPresentation = TypeChecker.fromName(
+    'BlocPresentationMixin',
+    packageName: 'bloc_presentation',
+  );
+}