Eliminate ESLint Lint Errors #1241
Conversation
Signed-off-by: Rajesh-Nagarajan-11 <rajeshnagarajan36@gmail.com>
Signed-off-by: Rajesh-Nagarajan-11 <rajeshnagarajan36@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR eliminates ESLint lint errors across the codebase to ensure full compliance with the project's ESLint configuration, including the newly added eslint-plugin-import rules.
Changes:
- Added
eslint-plugin-importdependency and configured import ordering rules - Reordered import statements to comply with
import/firstrule - Replaced short-circuit expressions with explicit if statements for side effects
- Refactored React components for better type safety and component structure
- Enhanced useEffect hooks with reference tracking and deferred state updates
- Removed extraneous whitespace from markdown documentation files
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added eslint-plugin-import dependency |
| package-lock.json | Updated dependency lock with new import plugin and peer dependencies |
| eslint.config.js | Configured import plugin and added import/first rule |
| src/theme/theme.ts | Moved import statement to top of file |
| src/custom/ShareModal/ShareModal.tsx | Reordered imports to comply with linting rules |
| src/testing/ResponsiveDataTable.test.tsx | Reordered imports with React import first |
| system/patterns/empty-states.md | Removed extraneous blank lines |
| src/custom/Helpers/readme.md | Removed extraneous blank lines |
| src/custom/FlipCard/FlipCard.tsx | Replaced short-circuit expressions with explicit if statements |
| src/actors/worker/workerfy.ts | Replaced short-circuit expressions with explicit if statements |
| src/custom/CatalogDesignTable/CatalogDesignTable.tsx | Replaced short-circuit expression with explicit if statement |
| src/base/Hidden/Hidden.tsx | Modified ref forwarding pattern by wrapping MuiHidden in div |
| src/custom/CustomCatalog/CatalogCardDesignLogo.tsx | Moved SvgComponent definition outside parent and added missing props |
| src/custom/CatalogDetail/ContentClassInfo.tsx | Refactored inline ClassIcon component to direct Icon rendering |
| src/custom/CatalogDetail/LearningSection.tsx | Enhanced useEffect with ref tracking and queueMicrotask |
| src/custom/CatalogDetail/ChallengesSection.tsx | Enhanced useEffect with ref tracking and queueMicrotask |
| src/testing/routing.test.ts | Updated type assertion for invalid resource type test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| useEffect(() => { | ||
| if (autoUpdate) { | ||
| setOpenLearning(Boolean((filteredAcademyData?.['learning-path'] ?? []).length > 0)); | ||
| if (autoUpdate && prevDataRef.current !== filteredAcademyData) { | ||
| prevDataRef.current = filteredAcademyData; | ||
| queueMicrotask(() => { | ||
| setOpenLearning(Boolean((filteredAcademyData?.['learning-path'] ?? []).length > 0)); | ||
| }); | ||
| } |
There was a problem hiding this comment.
The useEffect with queueMicrotask introduces unnecessary complexity. Using queueMicrotask to defer state updates can lead to unexpected timing issues and may not provide the intended benefit. The reference tracking with prevDataRef and the queueMicrotask pattern could be simplified to a more straightforward dependency check. Consider if the queueMicrotask is truly necessary or if a simpler effect implementation would suffice.
| useEffect(() => { | ||
| if (autoUpdate) { | ||
| setOpenChallenges((filteredAcademyData?.['challenges'] ?? []).length > 0); | ||
| if (autoUpdate && prevDataRef.current !== filteredAcademyData) { | ||
| prevDataRef.current = filteredAcademyData; | ||
| queueMicrotask(() => { | ||
| setOpenChallenges((filteredAcademyData?.['challenges'] ?? []).length > 0); | ||
| }); | ||
| } |
There was a problem hiding this comment.
The useEffect with queueMicrotask introduces unnecessary complexity. Using queueMicrotask to defer state updates can lead to unexpected timing issues and may not provide the intended benefit. The reference tracking with prevDataRef and the queueMicrotask pattern could be simplified to a more straightforward dependency check. Consider if the queueMicrotask is truly necessary or if a simpler effect implementation would suffice.
Signed-off-by: Rajesh-Nagarajan-11 <rajeshnagarajan36@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Rajesh Nagarajan <139469505+Rajesh-Nagarajan-11@users.noreply.github.com>
|
I will verify the Balance Co-Pilot review and proceed to finalize this PR. |
1 participant
Notes for Reviewers
This PR addresses and resolves all outstanding ESLint lint errors across the codebase. Key changes include:
Signed commits