Phase 2A+2B: Hibernate 6 JAR swap + javax→jakarta migration#2
Draft
megamattron wants to merge 3 commits intomodernizationfrom
Draft
Phase 2A+2B: Hibernate 6 JAR swap + javax→jakarta migration#2megamattron wants to merge 3 commits intomodernizationfrom
megamattron wants to merge 3 commits intomodernizationfrom
Conversation
- Replace hibernate-core 5.6.5 with 6.6.4.Final - Replace javax.persistence-api 2.2 with jakarta.persistence-api 3.1.0 - Add jakarta.transaction-api 2.0.1 - Remove hibernate-c3p0, hibernate-ehcache, hibernate-commons-annotations, antlr-2.7.7, jboss-transaction-api jars - Rename all javax.persistence imports → jakarta.persistence in framework src, test-src, and samples-and-tests (94+ files) - Update dependencies.yml accordingly
In H6, PersistentMap moved from org.hibernate.collection.internal to org.hibernate.collection.spi. Update the import in JPABase.java. ant compile now passes with zero errors (one deprecation warning for getElementType() which is a separate concern).
… Blob, DB, dialects) - HibernateInterceptor: remove EmptyInterceptor, implement Interceptor directly; fix onCollection* methods from boolean to void return type (H6 API change) - Blob: update UserType<Blob> generic interface; int getSqlType() replaces int[] sqlTypes(); nullSafeGet now takes column position int not String[] names; drop StringType.INSTANCE - DB: replace SessionImpl.getSession().connection() with Session.doReturningWork() - EvolutionQuery: Oracle8iDialect -> OracleDialect - JPAPlugin: MySQL8Dialect->MySQLDialect, Oracle10gDialect->OracleDialect, remove H6-removed dialects (DB2400, DB2390, SybaseAnywhere, SAPDB, Informix, Ingres, Progress, Mckoi, Interbase, Pointbase, Frontbase, Firebird) - MySQLDialect: replace MySQLInnoDBDialect (removed in H6) with MySQLDialect base
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
javax.persistence-api 2.2withjakarta.persistence-api 3.1.0andjakarta.transaction-api 2.0.1hibernate-c3p0,hibernate-ehcache,hibernate-commons-annotations,antlr-2.7.7,jboss-transaction-apijavax.persistenceimports →jakarta.persistenceacross 94+ files (framework src, test-src, and all sample apps)PersistentMapimport:org.hibernate.collection.internal→org.hibernate.collection.spi(H6 package reorganization)dependencies.ymlto reflect new artifact coordinatesResult
ant compilepasses with zero errors. One deprecation warning remains (getElementType()onCollectionPersister) which is a separate concern.ant unittesthas one pre-existing failure (GroovyTemplateTest) due to Groovy 3.0.22's bundled ASM not supporting the current JDK class file version — this failure exists onmodernizationbefore these changes.Test plan
ant compile— passes (zero errors)ant unittest— same pass/fail ratio asmodernizationbaseline (onlyGroovyTemplateTestfails, pre-existing)javax.persistencesymbols remain in framework or sample app source files