Highmaps bugfix and CSSsource clear.#89
Open
zottacko wants to merge 8 commits intokyper-data:masterfrom
Open
Conversation
On the content.html file a $.parseJSON(); call was missing when adding custom GeoJSON map.
Updated JSsource list to Highmaps 9 links since many of the previous versions doesn't seem to work properly. Also removed 'https://www.highcharts.com/highslide/highslide.css' from CSSsource since it's not available anymore.
Removed 'https://www.highcharts.com/highslide/highslide.css' from CSSsource since it's not available anymore.
Removed 'https://www.highcharts.com/highslide/highslide.css' from CSSsource since it's not available anymore.
added highcharts specification for drilldown
Added highcherts version 9 for drilldown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file
highmaps/templates/content.htmlhas a bug that prevents JavaScript from parsing a custom GeoJSON map. Added a$.parseJSON();call to fix it.Most of Highcharts 6 libraries for Maps don't work properly, so
JSsourcelinks were updated to version 9. Most maps work fine with version 7, but when adding a custom GeoJSON map, the least version needed is 9.The CSS
https://www.highcharts.com/highslide/highslide.cssis not available anymore so it's been removed fromCSSsourcedefinitions onhighcharts/highcharts.py,highmaps/highmaps.py, andhighstocks/highstocks.py.