Add alternate 'never' option to SHUNIT_COLOR, per the docs#99
Open
Maxattax97 wants to merge 1 commit intokward:masterfrom
Open
Add alternate 'never' option to SHUNIT_COLOR, per the docs#99Maxattax97 wants to merge 1 commit intokward:masterfrom
Maxattax97 wants to merge 1 commit intokward:masterfrom
Conversation
kward
requested changes
Feb 9, 2019
Owner
kward
left a comment
kward
left a comment
There was a problem hiding this comment.
The code uses 'none', so perhaps you could fix your CL to update the incorrect comment and the README.md instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this while referencing the docs, but in the implementation it only allows 'none'.
Maybe it's better to alter the docs to say 'none' rather than 'never', but that's up to you the maintainer.