fixed frame change on in-call status bar#101
Open
bonyadmitr wants to merge 2 commits intokukushi:masterfrom
Open
fixed frame change on in-call status bar#101bonyadmitr wants to merge 2 commits intokukushi:masterfrom
bonyadmitr wants to merge 2 commits intokukushi:masterfrom
Conversation
Owner
|
@bonyadmitr Thanks for your PR. How could I reproduce this case? Using "Toggle in-call Status bar" doesn't seem to trigger the function call? |
Author
I'm a little bit confused. It should be called. |
get last changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it is better to implement logic on UIApplication.willChangeStatusBarFrameNotification notification for good animation, but it will take lots changes for frames. this one is hot fix and will change frame at the end of status bar animation.
It can be tested in simulator by Hardware - Toggle in-call Status bar