separate type bounds and apply clippy lint fixes

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "structdiff"
-version = "0.7.1"
+version = "0.7.2"
 edition = "2021"
 license = "Apache-2.0 OR MIT"
 repository = "https://github.com/knickish/structdiff"
@@ -22,9 +22,12 @@ structdiff-derive   = { path = "derive", version = "=0.7.1" }
 "generated_setters" = ["structdiff-derive/generated_setters"]
 "rustc_hash"    = ["dep:rustc-hash"]
 "debug_asserts" = []
-"__rope_benchmarks" = []
 
 [dev-dependencies]
 bincode             = "1.3.3"
 assert_unordered    = "0.3.5"
-nanorand    = { version = "0.7.0" } 
+nanorand            = "0.7.0"
+pretty_assertions   = "1.4.1"
+
+[lints.rust]
+unexpected_cfgs = { level = "warn", check-cfg = ['cfg(unused)'] }

benchmarks/Cargo.toml

@@ -36,7 +36,3 @@ harness = false
 [[bench]]
 name = "large"
 harness = false
-
-[[bench]]
-name = "rope"
-harness = false

derive/Cargo.toml

@@ -19,3 +19,6 @@ serde               = { version = "^1.0.0", optional = true, features = ["derive
 "serde"     = ["dep:serde"]
 "debug_diffs" = []
 "generated_setters" = []
+
+[lints.rust]
+unexpected_cfgs = { level = "warn", check-cfg = ['cfg(unused)'] }

src/collections/mod.rs

@@ -1,7 +1,3 @@
-#[cfg(feature = "__rope_benchmarks")]
-pub mod rope;
-
-#[cfg(not(feature = "__rope_benchmarks"))]
 pub(crate) mod rope;
 
 pub mod unordered_array_like;

src/collections/ordered_array_like.rs

@@ -24,7 +24,6 @@
             source_end: source.len(),
         },
     )
-    .into_iter()
     .collect::<Vec<_>>()
     {
         empty if empty.is_empty() => None,
@@ -52,7 +51,6 @@
             source_end: source.len(),
         },
     )
-    .into_iter()
     .collect::<Vec<_>>()
     {
         empty if empty.is_empty() => None,
@@ -239,7 +237,7 @@
     let mut target_forward = target_start..target_end;
     let mut target_rev = (target_end..target_start).rev();
 
     let (target_range, source_range): (
         &mut dyn Iterator<Item = usize>,
         Box<dyn Fn() -> Box<dyn Iterator<Item = usize>>>,
     ) = match rev {
@@ -314,8 +312,8 @@
         (false, true) => {
             let iter: Box<dyn Iterator<Item = _>> = Box::new(
                 target[target_start..target_end]
-                    .into_iter()
-                    .map(|a| *a)
+                    .iter()
+                    .copied()
                     .enumerate()
                     .map(|(i, v)| {
                         let idx = source_end + i;
@@ -367,8 +365,8 @@
         .unwrap();
 
     let left = hirschberg_impl(
-        &target,
-        &source,
+        target,
+        source,
         Indices {
             target_end: target_split_index,
             source_end: source_split_index,
@@ -377,8 +375,8 @@
     );
 
     let right = hirschberg_impl(
-        &target,
-        &source,
+        target,
+        source,
         Indices {
             target_start: target_split_index,
             source_start: source_split_index,
@@ -561,8 +559,8 @@
 
     changelist_from_change_table(
         table,
-        &target,
-        &source,
+        target,
+        source,
         Indices {
             target_start,
             target_end,