Open
Conversation
|
@hcebke any chance you could look into this please? Can it be merged or not really? |
kfix
requested changes
Jun 1, 2023
Owner
kfix
left a comment
kfix
left a comment
There was a problem hiding this comment.
sorry for the delay, life is busy.
just one nit, otherwise looks fine
| if (displayUid != NULL) { | ||
| char *endptr; | ||
| uint uid = strtol(displayUid, &endptr, 10); | ||
| if (endptr == displayUid) { |
Owner
There was a problem hiding this comment.
rather should be checking that uid == 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the option
-dito allow specifying the display by its ID instead of its (arbitrary, non-permanent) list index.So far,
-dwas the only way to specify which display to send commands to. This refers to the list index of the display. Unfortunately, sometimes, depending on extraneous factors such as the order in which displays were plugged in, the order of the list changes. In order to reliably specify the same display every time, I added the-dioption that allows the user to specify thedisplayIDas shown byddcctl. At least on my setup, this ID remains constant.To test this feature, run
ddcctlonce to see the availabledisplayIDvalues on your system. Pick one, runddcctl -di <DISPLAY_ID>. It acts the same as if you didddcctl -d <POSITION_OF_DISPLAY_IN_LIST>.This fix might also be a viable workaround for #85.