Conversation
Formatting is poor (block is not indented correctly)
dhardy
force-pushed
the
push-qvnxkzltnmoz
branch
from
b22b9c3 to
da4a8d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds highlighting support over syntect and enables this in the gallery's Markdown editor and in examples/text-editor.
Performance is a bit slow, especially in debug builds. So far highlighting (re)processes the entire input at once; fixing this (limiting to shown lines) should help.
The syntect (Sublime) highlighter is limited to typical effects: bold (on/off), italic (on/off), underline, text and background colours. It would be nice if it supported a few other things (e.g. a lighter font weight in comments, using the monospace font family within Markdown code blocks) — alas, highlighters don't typically do this.
Known issue: background colours are used everywhere; ideally these should be made transparent and the text background should use the highlighter's theme colours.