some cleanup after FFI improvements #598
Merged
+77
−174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the nice idea of JS emulation while cut down some kludges from the implementation. Hopefully uncontroversial :)
ffi.lispis back to target, emulation goes tocompat.lisp.read-jhelpers incompat.lispno longer needed,read-jgoes toread.lisp.convert-xstringis inlined tojsstring(under no other circumstance it should be used). Fix a danglingconvert-xstringwhich should have beenconvert-property-keyliteral!) inconvertfor the branch that outsource toliteral, then there's acondinliteralthat has no catch-all branch (will return NIL if falls through, too bad!). I changed it so that catch all branch inconvertoutsource toliteral(all atomic value without special meaning should rightfully be handled this way), then catch all branch inliteralerrors.