Removed label requirement for first argument in transceive#24
Open
priteshshah1983 wants to merge 1 commit intojpsim:masterfrom
Open
Removed label requirement for first argument in transceive#24priteshshah1983 wants to merge 1 commit intojpsim:masterfrom
priteshshah1983 wants to merge 1 commit intojpsim:masterfrom
Conversation
This would make sure that the documentation in `README` works as expected
Owner
|
Could you instead fix the REAMDE? The Swift 3 API Design Guidelines state that weakly-typed arguments should be labeled, so the API is correct, and I'd rather change the docs than break user's code. |
ykws
added a commit
to ykws/PeerKit
that referenced
this pull request
Oct 10, 2018
instead of jpsim#24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would make sure that the documentation in
READMEworks as expected