-
Notifications
You must be signed in to change notification settings - Fork 0
feat(ci-server): add logic for executing automated tests on webhook trigger #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…on test execution
…er automated testing
…d testing behaviour
|
The first time I compile the whole project and run tests, they fail on simpleTest. If I then rerun the tests they succeed the second time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review(pr): Correct the PR description and make sure everything runs.
- Edit the PR description to follow the
.github/PULL_REQUEST_TEMPLATE/feature_pull_request.md - Present in the PR description how you tested that previous and current code works (following the previous
README.mdinstructions and the new ones) - Present that all tests are successfull in the PR description
- Correct spelling in
README.md - Assign yourself to the PR
- Add label "feature" to PR
- For step 1 under "Test functionality" you can refer back to "Run the server" like this instead; 1. Run the server, see Run the server.
- Move all tests into
MainTest.javaand removePushParserTest.java
joss2002
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review(pr): approved changes
What does this PR do?
Add logic for executing automated tests on webhook trigger.
Update README with statement of contribution and documentation on the implementation.
Why is this change needed?
To make it possible for the CI server to automatically run tests on github push events
How to test
ngrokChecklist
Fixes #9