fix: surface swallowed errors across storage and MCP layers#18
Merged
josephgoksu merged 1 commit intomainfrom Feb 25, 2026
Merged
fix: surface swallowed errors across storage and MCP layers#18josephgoksu merged 1 commit intomainfrom
josephgoksu merged 1 commit intomainfrom
Conversation
- task_store: log corrupt JSON instead of silently discarding (7 scan fields + 3 clarify session fields + 4 draft_state unmarshal sites) - sqlite: replace blind _, _ migration pattern with column-existence checks so real ALTER TABLE errors get logged - policy/audit: log corrupt input JSON in both scan methods - mcp/handlers: log GetProjectRoot failures in explain and simplify handlers instead of silently using empty base path
Greptile SummaryReplaced silent error swallowing with proper error logging across storage and MCP layers. Previously, JSON unmarshal failures, DDL migration errors, and Key improvements:
All changes follow Go error handling best practices by logging at appropriate levels ( Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 010280b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_, _ = db.Exec(ALTER TABLE ...)migration pattern with proper column-existence checks viapragma_table_info. Real DDL errors now get logged.scanDecisionandscanDecisionRowsinstead of silently dropping it.GetProjectRootfailures in explain and simplify handlers instead of silently using an empty base path.Test plan
go build ./...compilesmake test-quickpasses--verbosethat corrupt JSON in DB now produces warning logs