fix: respect global flags consistently, surface swallowed errors#17
Merged
josephgoksu merged 1 commit intomainfrom Feb 25, 2026
Merged
fix: respect global flags consistently, surface swallowed errors#17josephgoksu merged 1 commit intomainfrom
josephgoksu merged 1 commit intomainfrom
Conversation
- ask: respect --quiet flag (was printing results unconditionally) - start: respect --quiet for banner, dashboard, and status messages - version: support --json output, --quiet prints bare version string - task start: respect --quiet on success message - task complete: log git commit/push failures to stderr instead of silently swallowing them (users had no idea their work wasn't pushed) - knowledge ingest: log DB errors on node upsert and link operations instead of silently dropping knowledge - Remove unused FilterByMinConfidence export
Owner
Author
Greptile SummaryFixed critical error handling bugs and improved CLI output consistency. The PR corrects inverted error logic in Key fixes:
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 7c02306 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ask,start,version, andtask startnow respect global output flags. Previously they printed unconditionally.FilterByMinConfidenceexport.Files
cmd/ask.goRenderAskResultwith!isQuiet()cmd/start.go!isQuiet()cmd/version.go--jsonsupport,--quietprints bare versioncmd/task.go!isQuiet()internal/app/task.gointernal/knowledge/ingest.gointernal/agents/verification/agent.goFilterByMinConfidenceTest plan
go build ./...passesmake test-quickpassestaskwing version --jsonoutputs{"version": "..."}taskwing version --quietoutputs bare version stringtaskwing ask "test" --quietproduces no output