Update Class Snippets#1873
Open
gukgurgel wants to merge 3 commits intojorgenschaefer:masterfrom
gukgurgel:master
Open
Update Class Snippets#1873gukgurgel wants to merge 3 commits intojorgenschaefer:masterfrom gukgurgel:master
gukgurgel wants to merge 3 commits intojorgenschaefer:masterfrom
gukgurgel:master
Conversation
A reference to the new/recommended syntax can be found in https://docs.python.org/3/library/functions.html#super Signed-off-by: Gustavo Gurgel <gukgurgel@gmail.com>
The way the snippet was set (one only snippet for both
super and sub classes) prompted the creation of super classes
of the kind:
class ClassName(object):
'''Doc'''
def __init__(self):
super().__init__()
...
calling the method super() in a subclass of 'object'
rises the 'useless-super-delegation' warning from
pylintrc.
This can be avoided by creating a separated snippet
for subclasses, in which the method super() has an
usefull effect.
Signed-off-by: Gustavo Gurgel <gukgurgel@gmail.com>
Signed-off-by: Gustavo Gurgel <gukgurgel@gmail.com>
Collaborator
|
Oh nice, I like the new snippet! I will say that even though py 2 has reached EOL, there are still plenty of ppl who will continue to use for a few years (At my previous company, there is no way we'll get off py2 until years later). Because of this, I'm towards leaving the |
Collaborator
|
I like the idea of having |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Address some problems of the snippet for creating classes, and they are:
PR checklist
Please make sure that the following things have been addressed (and check the relevant checkboxes):
For new features only: