dependencies : allow symfony 8, and test against PHP 8.5

[NicolasDievart]

Symfony 8 is soon to be released (https://symfony.com/releases/8.0)
8.0.0 RC3 was released 5 days ago.

I've added ^8.0 as an allowed version for symfony dependencies on this project.

I've added test against PHP 8.5 which was released the November 20th
I don't know how much tests and versions should be kept, I let it to you to tell me which should be added or removed

[damienalexandre]

Thanks, looks good to me.

We just need JanePHP to be updated as well:

Problem 1
- Root composer.json requires jane-php/json-schema ^7.4 -> satisfiable by jane-php/json-schema[v7.4.0, ..., v7.9.0].
- jane-php/json-schema[v7.4.0, ..., v7.5.5] require symfony/console ^4.4 || ^5.0 || ^6.0 -> found symfony/console[v4.4.0, ..., v4.4.49, v5.0.0, ..., v5.4.47, v6.0.0, ..., v6.4.27] but these were not loaded, likely because it conflicts with another require.
- jane-php/json-schema[v7.6.0, ..., v7.9.0] require symfony/console ^5.4 || ^6.4 || ^7.0 -> found symfony/console[v5.4.0, ..., v5.4.47, v6.4.0, ..., v6.4.27, v7.0.0, ..., v7.3.6] but these were not loaded, likely because it conflicts with another require.

[NicolasDievart]

With the release of Jane, the install is working

composer install
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Package operations: 93 installs, 0 updates, 0 removals
  - Installing php-http/discovery (1.20.0): Extracting archive
  - Installing composer/pcre (3.3.2): Extracting archive
  - Installing psr/log (3.0.2): Extracting archive
  - Installing psr/http-message (2.0): Extracting archive
  - Installing psr/http-factory (1.1.0): Extracting archive
  - Installing psr/http-client (1.0.3): Extracting archive
  - Installing php-http/promise (1.3.1): Extracting archive
  - Installing php-http/httplug (2.4.1): Extracting archive
  - Installing symfony/polyfill-php82 (v1.33.0): Extracting archive
  - Installing open-telemetry/context (1.4.0): Extracting archive
  - Installing open-telemetry/api (1.7.1): Extracting archive
  - Installing nyholm/psr7 (1.8.2): Extracting archive
  - Installing elastic/transport (v9.0.1): Extracting archive
  - Installing symfony/deprecation-contracts (v3.6.0): Extracting archive
  - Installing psr/container (2.0.2): Extracting archive
  - Installing symfony/service-contracts (v3.6.1): Extracting archive
  - Installing symfony/stopwatch (v8.0.0): Extracting archive
  - Installing symfony/process (v8.0.0): Extracting archive
  - Installing symfony/polyfill-php84 (v1.33.0): Extracting archive
  - Installing symfony/polyfill-php81 (v1.33.0): Extracting archive
  - Installing symfony/polyfill-php80 (v1.33.0): Extracting archive
  - Installing symfony/polyfill-mbstring (v1.33.0): Extracting archive
  - Installing symfony/options-resolver (v7.4.0): Extracting archive
  - Installing symfony/finder (v8.0.0): Extracting archive
  - Installing symfony/polyfill-ctype (v1.33.0): Extracting archive
  - Installing symfony/filesystem (v7.4.0): Extracting archive
  - Installing psr/event-dispatcher (1.0.0): Extracting archive
  - Installing symfony/event-dispatcher-contracts (v3.6.0): Extracting archive
  - Installing symfony/event-dispatcher (v8.0.0): Extracting archive
  - Installing symfony/polyfill-intl-normalizer (v1.33.0): Extracting archive
  - Installing symfony/polyfill-intl-grapheme (v1.33.0): Extracting archive
  - Installing symfony/string (v8.0.0): Extracting archive
  - Installing symfony/console (v7.4.0): Extracting archive
  - Installing sebastian/diff (7.0.0): Extracting archive
  - Installing react/event-loop (v1.6.0): Extracting archive
  - Installing evenement/evenement (v3.0.2): Extracting archive
  - Installing react/stream (v1.4.0): Extracting archive
  - Installing react/promise (v3.3.0): Extracting archive
  - Installing react/cache (v1.2.0): Extracting archive
  - Installing react/dns (v1.14.0): Extracting archive
  - Installing react/socket (v1.17.0): Extracting archive
  - Installing react/child-process (v0.6.6): Extracting archive
  - Installing fidry/cpu-core-counter (1.3.0): Extracting archive
  - Installing composer/xdebug-handler (3.0.5): Extracting archive
  - Installing composer/semver (3.4.4): Extracting archive
  - Installing clue/ndjson-react (v1.3.0): Extracting archive
  - Installing friendsofphp/php-cs-fixer (v3.91.2): Extracting archive
  - Installing symfony/yaml (v7.4.0): Extracting archive
  - Installing symfony/var-dumper (v7.4.0): Extracting archive
  - Installing symfony/translation-contracts (v3.6.1): Extracting archive
  - Installing symfony/polyfill-php83 (v1.33.0): Extracting archive
  - Installing symfony/validator (v7.4.0): Extracting archive
  - Installing symfony/serializer (v7.4.0): Extracting archive
  - Installing nikic/php-parser (v5.6.2): Extracting archive
  - Installing php-jsonpointer/php-jsonpointer (v4.0.0): Extracting archive
  - Installing league/uri-interfaces (7.6.0): Extracting archive
  - Installing league/uri (7.6.0): Extracting archive
  - Installing jane-php/json-schema-runtime (v7.9.0): Extracting archive
  - Installing doctrine/inflector (2.1.0): Extracting archive
  - Installing jane-php/json-schema (v7.9.0): Extracting archive
  - Installing webmozart/assert (1.12.1): Extracting archive
  - Installing phpstan/phpdoc-parser (2.3.0): Extracting archive
  - Installing phpdocumentor/reflection-common (2.2.0): Extracting archive
  - Installing doctrine/deprecations (1.1.5): Extracting archive
  - Installing phpdocumentor/type-resolver (1.12.0): Extracting archive
  - Installing phpdocumentor/reflection-docblock (5.6.5): Extracting archive
  - Installing phpstan/phpstan (2.1.32): Extracting archive
  - Installing psr/clock (1.0.0): Extracting archive
  - Installing elasticsearch/elasticsearch (v9.2.0): Extracting archive
  - Installing ruflin/elastica (9.0.0): Extracting archive
  - Installing symfony/dom-crawler (v8.0.0): Extracting archive
  - Installing symfony/browser-kit (v8.0.0): Extracting archive
  - Installing psr/cache (3.0.0): Extracting archive
  - Installing symfony/cache-contracts (v3.6.0): Extracting archive
  - Installing symfony/routing (v8.0.0): Extracting archive
  - Installing symfony/polyfill-php85 (v1.33.0): Extracting archive
  - Installing symfony/http-foundation (v8.0.0): Extracting archive
  - Installing symfony/error-handler (v8.0.0): Extracting archive
  - Installing symfony/http-kernel (v8.0.0): Extracting archive
  - Installing symfony/var-exporter (v8.0.0): Extracting archive
  - Installing symfony/dependency-injection (v8.0.0): Extracting archive
  - Installing symfony/config (v8.0.0): Extracting archive
  - Installing symfony/cache (v8.0.0): Extracting archive
  - Installing symfony/framework-bundle (v8.0.0): Extracting archive
  - Installing symfony/http-client-contracts (v3.6.0): Extracting archive
  - Installing symfony/http-client (v8.0.0): Extracting archive
  - Installing symfony/clock (v8.0.0): Extracting archive
  - Installing symfony/messenger (v8.0.0): Extracting archive
  - Installing symfony/phpunit-bridge (v8.0.0): Extracting archive
  - Installing symfony/type-info (v8.0.0): Extracting archive
  - Installing symfony/property-info (v8.0.0): Extracting archive
  - Installing symfony/property-access (v8.0.0): Extracting archive
  - Installing symfony/psr-http-message-bridge (v8.0.0): Extracting archive

Can you retry the tests ?

[damienalexandre]

Version v7.10.0 of Jane has been released, so now tests are green on the Symfony 8 side.

• Can you remove jane 8 from the composer.json?
• Can you fix the phpstan issue?

Then it should be ready!

Thanks a lot again.

[NicolasDievart]

The phpstan issues are fixed

As the LogicException was already in the uncheckedExceptionClasses, I've added the RuntimeException with it, as they are native exception (instead of adding the phpdoc comment). If you prefer the phpdoc doc comment, let me know.

And I've removed the ignored errors on NodeDefinition::children undefined method as it seems not to be triggerd anymore

[damienalexandre]

Thanks a lot !

[VincentLanglet]

The phpstan issues are fixed

As the LogicException was already in the uncheckedExceptionClasses, I've added the RuntimeException with it, as they are native exception (instead of adding the phpdoc comment). If you prefer the phpdoc doc comment, let me know.

It does not ignore only those exception but also all the exception extending them.
While LogicException are often ignored because they are exception which "shouldn't occur" unless dev make a mistake, that's not the case of the RuntimeException.

If the check is "useless" for the getConfigTreeBuilder method, it might be useful for lot of other methods of this project so I recommend to add the phpdoc and not ignore the phpstan check, like #221