Skip to content

Comments

feat: add supports for JsonStreamer on indexation#218

Merged
damienalexandre merged 13 commits intojolicode:masterfrom
GaryPEGEOT:feat/json-streamer-support
Jan 11, 2026
Merged

feat: add supports for JsonStreamer on indexation#218
damienalexandre merged 13 commits intojolicode:masterfrom
GaryPEGEOT:feat/json-streamer-support

Conversation

@GaryPEGEOT
Copy link
Contributor

Fixes #216

Copy link
Member

@damienalexandre damienalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this nice addition 👍

Would there be a way to make it less "intrusive", meaning having less changes in the core classes signatures?

Otherwise I guess it can only be a major release bump 🤔

@GaryPEGEOT GaryPEGEOT changed the title (Draft) feat: add supports for JsonStreamer on indexation feat: add supports for JsonStreamer on indexation Nov 17, 2025
@GaryPEGEOT
Copy link
Contributor Author

Saddly I cannot use the JsonStreamer to read the response as it uses the denormalizer (which is normal as data is already an array at this point)

@damienalexandre
Copy link
Member

Hello, happy new year ^^ I think we can move forward with this, I'm just not sure if this must be a version 3.0 and 2.2.

Can I ask for a changelog entry and even a bit of documentation? 😋 That would help 🙏 Thanks

@GaryPEGEOT
Copy link
Contributor Author

Hello, happy new year ^^ I think we can move forward with this, I'm just not sure if this must be a version 3.0 and 2.2.

Can I ask for a changelog entry and even a bit of documentation? 😋 That would help 🙏 Thanks

Happy new year! I've added changelog & doc entries

@damienalexandre damienalexandre merged commit 43fac5c into jolicode:master Jan 11, 2026
15 checks passed
@damienalexandre
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC: Add Support for Symfony JsonStreamer

4 participants